Skip to content
This repository has been archived by the owner on Apr 10, 2019. It is now read-only.

Archive gometalinter #590

Closed
alecthomas opened this issue Feb 7, 2019 · 22 comments
Closed

Archive gometalinter #590

alecthomas opened this issue Feb 7, 2019 · 22 comments

Comments

@alecthomas
Copy link
Owner

alecthomas commented Feb 7, 2019

The gometalinter GitHub project will be archived on 2019-04-07. Releases will still be available for download but no further code will be committed and issues will be read-only.

Switch to golangci-lint.

Many thanks to all contributors, in particular @dnephin who has helped me maintain gometalinter for the last year or two.

Edit: Just to be clear: binary downloads will still be available and the repository will remain, it will just become read-only and all development will cease. Any existing projects that use gometalinter will continue to work.

@quasilyte
Copy link

Please, don't be too fast with this decision.
Let this issue be open for at least several weeks.
Maybe someone would have good arguments in favor of not doing it.

My first step outside of "go lint only" was gometalinter, so I feel nostalgic. :(

@dnephin
Copy link
Collaborator

dnephin commented Feb 7, 2019

I do not have much time to maintain the project. At most I seem to have a bit of time to answer the occasional question on the issue tracker.

Maybe a first option could be to add a note at the top of the README and in the issue template saying something like the above (current maintainers are considering archiving the project, if you are interested in taking over please say something).

If nothing changes over the next few (maybe 6?) months then I guess archiving would seem like an acceptable option.

I can volunteer to make those changes sometime over the next week or so if that is what we decide.

@alecthomas
Copy link
Owner Author

That sounds reasonable.

  1. Put a note in the README of our intentions.
  2. Archive it in 3 months.

@lkysow
Copy link

lkysow commented Feb 27, 2019

@alecthomas thanks so much for all your hard work on this project! It's had a measurable impact on runatlantis/atlantis and found a couple of bugs I'd missed.

Golangci-lint almost has feature parity so I think EOL'ing this project is a totally legit decision.

🥂 Cheers and thanks again! 🥂

@alecthomas
Copy link
Owner Author

You're welcome.

I'll archive the project on April 7th.

@cristaloleg
Copy link
Contributor

Thank you for all your great work @alecthomas 💯

@alecthomas
Copy link
Owner Author

I've updated the title and README accordingly.

@thrasher-
Copy link

thrasher- commented Feb 27, 2019

Thanks for making such a great project @alecthomas & @dnephin!

@Azuka
Copy link

Azuka commented Feb 28, 2019

Thanks for all the work @alecthomas!

@cixtor
Copy link

cixtor commented Feb 28, 2019

Thank you for all the hard work @alecthomas and @dnephin .

I was going to offer my help to keep the development of the project alive, especially adding more concurrency and recycled buffers, but I realized that taking care of all the code, issue tracker, and —possibly— editor plugins would require a significant amount of time. I would also end up rewriting the entire code base and releasing a binary very similar to golangci-lint, so maybe it’s not worth the trouble.

I still like gometalinter more than golanci-lint.

Yesterday I spent a few hours creating a new version of the SublimeLinter package for golangci-lint, an improvement over this [1]. Unfortunately, after learning a bit more about this linter, I started to dislike it, especially the fact that some warnings are sent to /dev/stderr and others to /dev/stdout . It also seems to encourage people to configure its behavior using a configuration file, and considering how opinionated Go is, I was expecting something more simple, a plug-and-play sort of thing.

Thank you, once again, and let us hope golangci-lint gets better to justify the switch.

[1] https://github.com/alecthomas/SublimeLinter-contrib-golang-cilint

suzuki-shunsuke added a commit to suzuki-shunsuke/go-errlog that referenced this issue Mar 2, 2019
suzuki-shunsuke added a commit to suzuki-shunsuke/go-errlog that referenced this issue Mar 2, 2019
ifraixedes added a commit to ifraixedes/one-page-static-site that referenced this issue Mar 2, 2019
* Register the Go tools installed in the project using the Go modules
  way.
* Track the specific version of the used tools.
* Refactor Makefile for installing the tools in the same project
  directory for not overriding other binaries installed in the default
  GOBIN path of the machine.
* The changes in the Makefile has also simplified its targets and added
  a new target for executing the test.
* Changed the linter because gometanlinter is deprecated. See
  alecthomas/gometalinter#590
ifraixedes added a commit to ifraixedes/one-page-static-site that referenced this issue Mar 2, 2019
* Register the Go tools installed in the project using the Go modules
  way.
* Track the specific version of the used tools.
* Refactor Makefile for installing the tools in the same project
  directory for not overriding other binaries installed in the default
  GOBIN path of the machine.
* The changes in the Makefile has also simplified its targets and added
  a new target for executing the test.
* Changed the linter because gometanlinter is deprecated. See
  alecthomas/gometalinter#590
@slydon
Copy link

slydon commented Apr 2, 2019

golangci-lint as GPLv3 is a major headache for many commercial companies and in some cases an insurmountable barrier. I just wanted to point it out. I am not saying you shouldn't do what you need to do with this project. Do you have other non-GPLv3 recommendations?

@alecthomas
Copy link
Owner Author

I'm not aware of any other alternatives, no.

Given that golangci-lint is a tool, not a library, I'd say any objections to its use based on it being GPLv3 are issues brought about by corporate policy, not practicality. Additionally, they offer a commercial solution.

@lpar
Copy link

lpar commented Apr 9, 2019

golangci-lint as GPLv3 is a major headache for many commercial companies and in some cases an insurmountable barrier.

If you want to ship a commercial linter product, maybe fork the code and maintain it yourself?

@alecthomas
Copy link
Owner Author

Well, it's time.

Thanks again to all the contributors over the years, in particular @dnephin, and all the users who've been helpful.

So long, and thanks for all the fish.

@paveg paveg mentioned this issue Sep 20, 2019
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests