Bump Golang 1.12.3

[tao12345666333]

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

- What I did

go1.12.3 (released 2019/04/08) fixes an issue where using the prebuilt binary releases on older versions of GNU/Linux led to failures when linking programs that used cgo. golang/go#31293

see: https://github.com/golang/go/issues?utf8=✓&q=milestone%3AGo1.12.3

[tao12345666333]

This change is because of no newline at end of file.

[tao12345666333]

as @thaJeztah said,

I'm actually thinking of removing this "pin by digest", as it doesn't add much for our use-case 🤔

I also agree very much. Do we need to remove this "pin by digest" ? 🤔

[thaJeztah]

I am ok with removing it

@vdemeester @silvin-lubecki SGTY?

[tao12345666333]

It seems that the lint task failed, I ran the lint task locally and found that it takes 4m+.

/go/src/github.com/docker/cli # time /usr/local/bin/gometalinter --config=gometalinter.json ./...
real    4m 55.06s
user    1m 55.14s
sys     0m 26.43s

should we increasing deadline? 🤔

[codecov-io]

Codecov Report

Merging #1818 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1818   +/-   ##
=======================================
  Coverage   56.31%   56.31%           
=======================================
  Files         308      308           
  Lines       21429    21429           
=======================================
  Hits        12068    12068           
  Misses       8476     8476           
  Partials      885      885

[tao12345666333]

And I found gometalinter has been archived by the owner. alecthomas/gometalinter#590

should we change to use golangci-lint or other active lint tool?

[thaJeztah]

Thanks!

Left one question about the timeout, and let's wait for the others to reply wrt the digest

[thaJeztah]

I am ok with removing it

@vdemeester @silvin-lubecki SGTY?

[thaJeztah]

For the linter: I just recalled there's a pull request to replace it (that I didn't review yet 🤭🤫😳) #1797

[thaJeztah]

Interesting;

cli/command/formatter/reflect_test.go:15:34:warning: nolint directive did not match any issue (nolint)
WARNING: deadline exceeded by linter unused (try increasing --deadline)
Exited with code 3

[thaJeztah]

( nolint directive did not match any issue (nolint))

[tao12345666333]

For the linter: I just recalled there's a pull request to replace it (that I didn't review yet 🤭🤫) #1797

Sorry, I didn't notice its existence. I just tried to change gometalinter to golangci-lint locally. 😆

[thaJeztah]

LGTM, all green now 👍

ping @vdemeester @silvin-lubecki

[vdemeester]

LGTM 🐯