-
Notifications
You must be signed in to change notification settings - Fork 267
Use a fork of go tool vet
to fix mutli-package directories
#375
Conversation
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
:( Unfortunate. Are you going to attempt to get this patch merged upstream? |
Ya, I'll try. Opened golang/go#22296 and https://go-review.googlesource.com/c/go/+/71170 |
It sounds like maybe this issue has been fixed as of go v1.9. We should be able to use |
I think this may have broken gometalinter, at least on travis getting
and looking around looks like other projects builds are failing as well. example travis file: https://github.com/dpastoor/babylon/blob/master/.travis.yml |
You'll have to install the forked Alternatively you can configure {
"Linters": {
"vet": {
"Command": "go tool vet"
}
}
} |
kk testing now... |
thanks for the tip - it works now 👍 |
for those that run into this PR just added + - gometalinter --install
- gometalinter --disable-all -E vet -E gofmt -E misspell -E ineffassign -E goimports -E deadcode --tests --vendor ./... in the script section for travis |
Fixes #351
Uses a govet fork with this patch dnephin/govet@4a96d43
This seems to fix the issue for me on the gotestyourself project.