Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix CI Tests #1929

Merged
merged 1 commit into from
Oct 19, 2017
Merged

CI: Fix CI Tests #1929

merged 1 commit into from
Oct 19, 2017

Conversation

elcore
Copy link
Collaborator

@elcore elcore commented Oct 19, 2017

1. What does this change do, exactly?

This change fixes the CI tests

2. Please link to the relevant issues.

n/a

3. Which documentation changes (if any) need to be made because of this PR?

n/a

4. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I am willing to help maintain this change if there are issues with it later

Sorry, something went wrong.

@mholt
Copy link
Member

mholt commented Oct 19, 2017

What was wrong with them? i.e. what does this do?

@elcore
Copy link
Collaborator Author

elcore commented Oct 19, 2017

What was wrong with them? i.e. what does this do?

gometalinter --disable-all -E vet -E gofmt -E misspell -E ineffassign -E goimports -E deadcode --tests --vendor ./...
WARNING: exec: "govet": executable file not found in $PATH

Reference: alecthomas/gometalinter#375 & https://travis-ci.org/mholt/caddy/jobs/290014984

@mholt
Copy link
Member

mholt commented Oct 19, 2017

Ahhh, gotcha. Thank you!

@mholt mholt merged commit 59a8ada into master Oct 19, 2017
@mholt mholt deleted the ci branch October 19, 2017 17:02
@francislavoie francislavoie mentioned this pull request Oct 19, 2017
4 tasks
@mholt mholt added this to the 0.10.11 milestone Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants