Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

add notify script via environment variable #79

Merged
merged 1 commit into from
Jan 23, 2019
Merged

add notify script via environment variable #79

merged 1 commit into from
Jan 23, 2019

Conversation

muhlba91
Copy link

keepalived supports executing notify scripts on events, which come in handy when having to react to events, e.g. when performing a failover, and trigger any update. In this specific case it is needed for Hetzner Failover/Floating IPs to perform a JSON API call to the Hetzner API and notify them about the changed IP assignment.

As mentioned in a comment in @cornelius-keller's PR kubernetes-retired/contrib#2912, this repository here is more maintained and, therefore, I have applied the necessary changes and hopefully this can get merged. :)

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 15.014% when pulling 2b0183e on muhlba91:notify_script into f3b9e29 on aledbf:master.

@aledbf
Copy link
Owner

aledbf commented Jan 22, 2019

@muhlba91 please sign the CLA

@muhlba91
Copy link
Author

@aledbf thanks for you rresponse. :) I have signed the CLA now.

@aledbf aledbf merged commit 826d2e3 into aledbf:master Jan 23, 2019
@aledbf
Copy link
Owner

aledbf commented Jan 23, 2019

@muhlba91 thanks!

@muhlba91
Copy link
Author

@aledbf cool, thanks for merging! :)
btw, when can we expect a new release containing this feature?

@cornelius-keller
Copy link

thanks @muhlba91 @aledbf , I am happy that this is merged finally somewhere else than in my private for!

@aledbf
Copy link
Owner

aledbf commented Jan 23, 2019

@muhlba91 now :) https://github.com/aledbf/kube-keepalived-vip/releases/tag/0.32

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants