Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

add option to use notfy scripts for keepalived #2912

Merged
merged 3 commits into from
Feb 11, 2019
Merged

add option to use notfy scripts for keepalived #2912

merged 3 commits into from
Feb 11, 2019

Conversation

cornelius-keller
Copy link
Contributor

Hi,
i modified keepalived-vip to add an option to use notify scripts.
My change should be 100% backwards compatible to the previous behavior.
It is enabled by mounting your notification script to the pod via a configmap, and then setting the env var KEEPALIVED_NOTIFY to the location where it is mounted. This will include a line like:
notify /opt/your-notify-script.sh to the keepalived config.

I use this feature on cloud providers were you need a special api call to get an failover / floating IP routed to your machine.

I would like to have this merged so that I don't have to maintain a fork of keepalived-vip.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2018
@cornelius-keller
Copy link
Contributor Author

/assign @bprashanth

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2018
@voron
Copy link

voron commented Sep 7, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2018
@pierreozoux
Copy link

pierreozoux commented Nov 27, 2018

@mikedanese or @bprashanth can you tell us how to move this forward? Or give us a name that could help us get this merged? Thanks!

@steven-sheehy
Copy link

@pierreozoux You might want to try the better maintained fork: https://github.com/aledbf/kube-keepalived-vip/

@pierreozoux
Copy link

@steven-sheehy I'd prefer an "official image". I'd like to avoid images maintained by third parties.
If there is none, then okay, I'll have to maintain my fork, and build my own image.
But if the official project delivers one, it would simplify the life of number of people including me.

@cornelius-keller
Copy link
Contributor Author

@pierreozoux I totally agree that it is best to have this in the official image and not maintain a custom fork of it. @mikedanese @bprashanth would be nice if we can get at least a review.
If there are changes required I am willing to put further effort into this but without having a clue what is missing this is difficult.

@loxy
Copy link

loxy commented Jan 14, 2019

Will that ever be included?

@muhlba91
Copy link

Is there any update on this PR? It would be great seeing this in the official image.

@mikedanese
Copy link
Contributor

@kubernetes/sig-network-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to sig-network. label Jan 22, 2019
@mikedanese mikedanese requested review from bowei and removed request for mikedanese and bprashanth January 22, 2019 18:57
@md2k
Copy link

md2k commented Feb 8, 2019

Hi all, can this be reviewed and merged guys?

@muhlba91
Copy link

fyi: as per @steven-sheehy's suggestion this has already been merged into https://github.com/aledbf/kube-keepalived-vip/ (PR: aledbf/kube-keepalived-vip#79)

@bowei
Copy link
Contributor

bowei commented Feb 11, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, cornelius-keller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1043fc9 into kubernetes-retired:master Feb 11, 2019
@cornelius-keller cornelius-keller deleted the keepalived_with_notify branch February 12, 2019 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to sig-network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.