Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the file icon from the theme #112

Merged
merged 3 commits into from
Jul 13, 2018
Merged

Use the file icon from the theme #112

merged 3 commits into from
Jul 13, 2018

Conversation

vbfox
Copy link
Contributor

@vbfox vbfox commented May 10, 2018

The icon for files in the treeview is now the one specified by the theme (same as the explorer view)

2018-05-10 23_31_15- extension development host - colorstrings fs - coloredprintf - visual studio c

@alefragnani
Copy link
Owner

Hi @vbfox ,

That's great! I remember seeing this request on VS Code repo, but didnt track its status. Its good to know it's finally available.

I'll try to merge and publish an update this weekend.

Thanks 👍

alefragnani
alefragnani requested changes May 14, 2018
View reviewed changes
Copy link
Owner

@alefragnani alefragnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, also remove the declaration of variable hasIcons at line 17, because it is not necessary anymore.

@alefragnani alefragnani added this to the 9.0 milestone Jun 12, 2018
@alefragnani alefragnani merged commit 88c22db into alefragnani:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alefragnani alefragnani alefragnani requested changes

Assignees
No one assigned
Labels
enhancement side bar
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vbfox @alefragnani