Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the file icon from the theme #112

Merged
merged 3 commits into from
Jul 13, 2018
Merged

Use the file icon from the theme #112

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
139b8e7
Use the current theme icons for files in the tree view
vbfox May 10, 2018
a86f83e
Remove now unused icons
vbfox May 10, 2018
88c22db
Remove hasIcons as it isn't used anymore
vbfox May 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion images/bookmark-explorer-dark.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion images/bookmark-explorer-light.svg
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"theme": "dark"
},
"engines": {
"vscode": "^1.18.0"
"vscode": "^1.22.0"
},
"categories": [
"Other"
Expand Down
9 changes: 3 additions & 6 deletions src/BookmarkProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,12 +273,9 @@ class BookmarkNode extends vscode.TreeItem {
super(label, collapsibleState);

if (kind === BookmarkNodeKind.NODE_FILE) {
if (hasIcons) {
this.iconPath = {
light: context.asAbsolutePath("images/bookmark-explorer-light.svg"),
dark: context.asAbsolutePath("images/bookmark-explorer-dark.svg")
};
}
this.resourceUri = vscode.Uri.file(bookmark.fsPath);
this.iconPath = vscode.ThemeIcon.File;
this.id = bookmark.fsPath;
this.contextValue = "BookmarkNodeFile";
} else {
this.iconPath = {
Expand Down