This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Improve discreet mode #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaivre
commented
May 18, 2023
nop33
reviewed
May 23, 2023
mvaivre
force-pushed
the
improve-discreet-mode
branch
from
c85aa9a to
a021f3d
Compare
mvaivre
force-pushed
the
improve-discreet-mode
branch
from
b4182c3 to
fa0bee0
Compare
nop33
reviewed
May 23, 2023
locales/de-DE/translation.json
Outdated
| @@ -421,5 +422,5 @@ | |||
| "Your addresses": "Ihre Adressen", | |||
| "Your CSV file has been generated successfully.": "Your CSV file has been generated successfully.", | |||
| "Your CSV file is being compiled in the background.": "Your CSV file is being compiled in the background.", | |||
| "Your Wallet": "Ihre Wallet" | |||
| "Your Wallet": "Your Wallet" | |||
There was a problem hiding this comment.
This translation was actually correct 😅
locales/id-ID/translation.json
Outdated
| @@ -421,5 +422,5 @@ | |||
| "Your addresses": "Your addresses", | |||
| "Your CSV file has been generated successfully.": "Your CSV file has been generated successfully.", | |||
| "Your CSV file is being compiled in the background.": "Your CSV file is being compiled in the background.", | |||
| "Your Wallet": "Dompet Anda" | |||
| "Your Wallet": "Your Wallet" | |||
locales/es-ES/translation.json
Outdated
| @@ -421,5 +422,5 @@ | |||
| "Your addresses": "Your addresses", | |||
| "Your CSV file has been generated successfully.": "Your CSV file has been generated successfully.", | |||
| "Your CSV file is being compiled in the background.": "Your CSV file is being compiled in the background.", | |||
| "Your Wallet": "Su billetera" | |||
| "Your Wallet": "Your Wallet" | |||
There was a problem hiding this comment.
I guess all that was needed was to capitalize the word billetera...
locales/pt-PT/translation.json
Outdated
| @@ -421,5 +422,5 @@ | |||
| "Your addresses": "Your addresses", | |||
| "Your CSV file has been generated successfully.": "Your CSV file has been generated successfully.", | |||
| "Your CSV file is being compiled in the background.": "Your CSV file is being compiled in the background.", | |||
| "Your Wallet": "A sua carteira" | |||
| "Your Wallet": "Your Wallet" | |||
There was a problem hiding this comment.
Not sure how to capitalize this one tho, so I'd leave it like this.
mvaivre
force-pushed
the
improve-discreet-mode
branch
from
fa0bee0 to
78062ba
Compare
nop33
approved these changes
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #677