Add SSPI context flag validation functions #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexbrainman PTAL |
|
This looks nice, thank you very much. But it would be useful for me and other users, if you could add calls to your new function in any of our existing tests. Is that possible? Alex |
I will look into this sometime this week. |
|
@alexbrainman PTAL at 9b3b824 |
|
Nice, thank you very much. Please, squash all commits into one, and I will merge. Alex |
This change adds two verification functions for SSPI context: VerifyFlags and VerifySelectiveFlags. The former is used to confirm that all flags requested for the context were honored. The latter is used to confirm if some subset of the requested flags were honored. Signed-off-by: Monis Khan <mkhan@redhat.com>
|
@alexbrainman squashed into one commit and rebased on master. |
6 tasks
|
Thank you very much. Submitting now. Alex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds two verification functions for SSPI context:
VerifyFlagsandVerifySelectiveFlags. The former is used to confirm that all flags requested for the context were honored. The latter is used to confirm if some subset of the requested flags were honored.Signed-off-by: Monis Khan mkhan@redhat.com