-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SSPI Support on Windows (oc Kerberos) #11371
Conversation
[test] to make sure it still builds... |
flake #11374 re-[test] |
Evaluated for origin test up to 9763453 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10877/) (Base Commit: 44f877c) |
Still hoping, huh? |
It already works, just is a pain to test... |
Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again |
/retest |
/refresh |
/retest |
6 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
1 similar comment
/retest |
@deads2k this PR was fully green yesterday, now it is all red again due to flakes, can we green button please ? I think we suffered enough the CI woes! /retest |
/test cmd |
/retest |
2 similar comments
/retest |
/retest |
This does not change the behavior of the code. Signed-off-by: Monis Khan <mkhan@redhat.com>
Required for SSPI support on Windows (for oc Kerberos). This dependency is owned by the auth team. Signed-off-by: Monis Khan <mkhan@redhat.com>
This change is highly experimental and includes no tests (because you need an automated extended test with a fully configured Windows Active Directory server to actually test this). Signed-off-by: Monis Khan <mkhan@redhat.com>
New changes are detected. LGTM label has been removed. |
@enj: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
1 year, 9 months and a million flakes later... |
pulls accepted :) |
Trello ref: https://trello.com/c/5BrQfA4H
TODO:
Extended testQA will handle testingLook at https://github.com/denisenkom/go-mssqldb/blob/master/sspi_windows.goalexbrainman/sspi is superior (related: https://github.com/WillHipschman/sspi-prototype and https://github.com/vmware/photon-controller-go-sdk/tree/master/SSPI)