Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add force-engine feature for enabling engine module #151

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

neuronull
Copy link

In one of our (vector.dev) project's dependencies (rdkafka), a hard dependency on openssl Engine support was added.
This resulted in cross compilation errors for our project (since openssl-src was not enabling the engine support), the findings were documented here:

vectordotdev/vector#10302

Allowing this engine feature support to be configurable would help unblock us.

Thanks!

@alexcrichton
Copy link
Owner

I'd recommend if you can doing an end-to-end integration test with this. This PR, for example, doesn't add a Cargo feature so there's no easy way to actually turn on this cfg other than with RUSTFLAGS which is probably not what you intended.

@neuronull
Copy link
Author

Ah yes... I think that is all I was missing.
I just completed cross compiling our project to musl, and patching the openssl-sys crate to use this fork and the new feature, and it succeeded.

@neuronull
Copy link
Author

Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants