Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature vendored-engine for engine support in openssl-src #1665

Closed

Conversation

neuronull
Copy link

@neuronull neuronull commented Jul 21, 2022

NOTE this change depends on the following PR being merged into openssl-src : alexcrichton/openssl-src-rs#150 , and thus CI will fail until that is made available. Posting this PR in anticipation of that for visibility.

One of our project dependency crates added a hard dependency on the openssl Engine module.

This created a problem when cross compiling with musl due to the disabling of the Engine module by openssl-src for the musl target.

By adding the option to enable Engine support in openssl-src , and adding this feature flag to openssl-sys to make use of that option, together this would unblock us .

@sfackler
Copy link
Owner

It seems like it would be better for this to be modeled as a Cargo feature in openssl-src like all of the other configuration.

@jszwedko
Copy link

@sfackler Agreed this should be a feature flag on openssl-src. Once that is added, we will need a new in openssl-sys to enable the flag on openssl-src though, right? Would you be open to that?

I.e. something like:

[features]
vendored = ['openssl-src']
+ vendored-engine = ['openssl-src/engine']

@neuronull
Copy link
Author

I submitted a new PR to openssl-src for the feature flag (alexcrichton/openssl-src-rs#151)

New PR because I needed to change to the 111 release.

@sfackler
Copy link
Owner

@jszwedko you don't need that:

[dependencies]
openssl = { version = "0.10", features = ["vendored"] }

[build-dependencies]
openssl-src = { version = "111", features = ["engine"] }

@neuronull
Copy link
Author

This was covered in alexcrichton/openssl-src-rs#151.

Closing

@neuronull neuronull closed this Jul 25, 2022
@neuronull neuronull deleted the neuronull/vendored-engine-feature branch July 25, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants