-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Added averages and date ranges to the panel dashboard #1669
base: main
Are you sure you want to change the base?
Conversation
This is awesome man, great work! Couple of quick comments:
On the topic of charts starting at 0 vs. within range of values. This has been a hot topic in the past and it comes down to preference, let's add an environment variable to control this instead. |
Thanks for the feedback! See below my answers, please let me know your thoughts.
No we don't, In one of the requests there was 3h,6h etc.. We could just only show the custom one, or only keep 24h, 1 week, 1 month next to the costom one.
I think it depends how often you test. When you test once a day, having a week makes sense. When you test every hour having 1 day makes sense. Thats one of the reasons I made it a env, so people can set it to there liking.
I experimented with DateTimePicker but couldn't get it to work reliably, especially with setting the hours. I'll give it another try.
Good idea, I will add it. Just wondering if we should do the same for the filling of the graph and the dots then. |
Ok, let's skip that for now then and we can circle back around to it in a patch.
I think I avoided fill back when the graphs were combined, it's just UI so I think we can leave it out of configurable options for now. When you add the config for starting at zero can you default to 0 so there is no change from current? |
Done! Added the env for the begin at 0, it will default to true so there is indeed no change. I will remove some of the pre-defined time ranges to keep it short |
One other quick note, can you change We'll also need to look into how to port this over to the public dashboard. |
Done as well :) Just to be sure the fill for the graph does not need to be a environment?
Yess, im sure how the public dashboard is build. Some guidiness on that would be appreciated :) |
Correct, let's skip the fill option. For the public dashboard we can do that work in a separate PR. |
Let's extract the failed changes to a separate PR, helps me do reviews faster if I'm only testing 1 or a couple things. That being said I think I like the gap in charting more. We could introduce a new chart that's a "failure rate" progress bar chart to show success/failure rates. I'm happy to work on that one separately. |
Sounds like a better plan. Lets keep it with what we have now and do the otherthings later :). |
I'll be able to test the PR tonight |
I have been trying to figure out why this happens, but no result so far. At the same time Im thinking user might not change the |
I'm going to give this a functionality review later tonight, thanks for all the work! |
Thanks man! One other idea I had was to remove to the predefined 24h, 1 week, 1 month and just only have the date/time picker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're also going to have to add these dashboard changes to the public dashboard in this release. I'll do some research on how to wrap the form and chart updates into that view.
@alexjustesen Not sure why it keeps saying that there are requested changes, already resolved the finding you noticed |
📃 Description
This PR introduces new functionalities and updates the data display on the dashboard.
The public dashboard is out of scope for this pr
Please double check the working of the time picker and env value before releasing to make sure it works as intended.
🪵 Changelog
➕ Added
- To close More granular Time Selection #448
- to close Only able to show speeds for the last month, am I missing something, or would it be a feature request #1776
CHART_TIME_RANGE
to set a default range in days, falls back to 7 days incase it's not set.- To close Save Dashboard #1449
- To close [FEATURE REQUEST] Setting the default range for charts on the dashboard #738
- To close Tables interval input always reset to "Last 24h" #1682
- To close Allow me to set Default timeframe on graphs #1698
- To close Displaying averages + deltas #243
- to close Adding a New Feature for Tracking Average WAN Speeds #1244
- to close [Feature Req] Please utilise text based min / max / avg summary, same as HenryWhittaker version #1408
- to close More Statistics like variance #1194
✏️ Changed
📷 Screenshots