This repository has been archived by the owner on Mar 8, 2022. It is now read-only.
Add SAML options to auth0_connection resource #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only support the options that are both readable and writable. Added an acceptance test and documentation
jbauth0
approved these changes
Jun 25, 2020
Co-authored-by: jbauth0 <49204697+jbauth0@users.noreply.github.com>
Co-authored-by: jbauth0 <49204697+jbauth0@users.noreply.github.com>
Co-authored-by: jbauth0 <49204697+jbauth0@users.noreply.github.com>
Co-authored-by: jbauth0 <49204697+jbauth0@users.noreply.github.com>
Co-authored-by: jbauth0 <49204697+jbauth0@users.noreply.github.com>
Co-authored-by: jbauth0 <49204697+jbauth0@users.noreply.github.com>
Co-authored-by: jbauth0 <49204697+jbauth0@users.noreply.github.com>
alexkappa
reviewed
Jun 29, 2020
auth0/structure_auth0_connection.go
Outdated
| "signing_cert": o.GetSigningCert(), | ||
| "protocol_binding": o.GetProtocolBinding(), | ||
| "debug": o.GetDebug(), | ||
| "idpinitiated": o.GetIdpInitiated(), |
There was a problem hiding this comment.
Shouldn't this be flattened as well?
auth0/structure_auth0_connection.go
Outdated
| ClientID: String(d, "client_id"), | ||
| ClientProtocol: String(d, "client_protocol"), | ||
| ClientAuthorizequery: String(d, "client_authorizequery"), | ||
| }, |
There was a problem hiding this comment.
I suspect there is an error here. String(d, "client_id") should be run inside a Set(d, "idpinitiated").Elem(...) block.
| } | ||
| } | ||
| } | ||
| ` |
There was a problem hiding this comment.
Could we add a test for updates? Some common issues tend to surface which get caught with update tests. Also please test the idpinitiated block.
auth0/resource_auth0_connection.go
Outdated
| "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST", | ||
| }, true), | ||
| }, | ||
| "idpinititated": { |
There was a problem hiding this comment.
We could make this a little more readable:
Suggested change
| "idpinititated": { | |
| "idp_inititated": { |
auth0/resource_auth0_connection.go
Outdated
| Type: schema.TypeString, | ||
| Optional: true, | ||
| }, | ||
| "client_authorizequery": { |
There was a problem hiding this comment.
Suggested change
| "client_authorizequery": { | |
| "client_authorize_query": { |
|
Awesome work @kgunbin thank you for this! Watch out for a new release soon. |
|
Yes - thank you for all your work @kgunbin! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on go-auth0/auth0#118
Proposed Changes
Acceptance Test Output
Community Note