Add mappings for the SAML type connection #118
Conversation
Co-authored-by: jbauth0 <49204697+jbauth0@users.noreply.github.com>
Co-authored-by: jbauth0 <49204697+jbauth0@users.noreply.github.com>
Co-authored-by: jbauth0 <49204697+jbauth0@users.noreply.github.com>
Co-authored-by: jbauth0 <49204697+jbauth0@users.noreply.github.com>
Co-authored-by: Alex Kalyvitis <alexkappa@github.com>
| @@ -227,7 +227,7 @@ func (m *Management) request(method, uri string, v interface{}) error { | |||
| return newError(res.Body) | |||
| } | |||
|
|
|||
| if res.StatusCode != http.StatusNoContent { | |||
| if res.StatusCode != http.StatusNoContent && res.StatusCode != http.StatusAccepted { | |||
There was a problem hiding this comment.
Could you give some context over this check? What caused a response of status accepted? Just curious..
There was a problem hiding this comment.
The tests were failing on the deletion step, and according to https://auth0.com/docs/api/management/v2#!/Connections/delete_connections_by_id it is expected that DELETE can respond with 202 instead of 204
I assume that would better come as a separate PR, but without this change I was unable to get tests green for alexkappa/terraform-provider-auth0#244
There was a problem hiding this comment.
Wow, I missed that! Thanks! And no worries, we can keep it in with this PR.
|
Many thanks for working on this @kgunbin! |
|
I've cut v4.4.0 if you would like to update alexkappa/terraform-provider-auth0#244. |
This PR adds the options for the SAML connection type.