Fix: Make Prod' universe-polymorphic
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeizer
approved these changes
Dec 4, 2024
Comment on lines
16
to
17
| def P : MvPFunctor.{u} 2 | ||
| := .mk PUnit fun _ _ => PFin2 1 |
There was a problem hiding this comment.
Suggested change
| def P : MvPFunctor.{u} 2 | |
| := .mk PUnit fun _ _ => PFin2 1 | |
| def P : MvPFunctor.{u} 2 := | |
| .mk PUnit fun _ _ => PFin2 1 |
The old formatting is a bit of a mess (my bad 😅), we should probably fix that to use the current standard style (i.e., put := on the same line as the type of the def) as we go along
Comment on lines
33
to
34
| def mk (a : Γ 1) (b : Γ 0) : QpfProd'.{u} Γ | ||
| := ⟨ |
There was a problem hiding this comment.
Suggested change
| def mk (a : Γ 1) (b : Γ 0) : QpfProd'.{u} Γ | |
| := ⟨ | |
| def mk (a : Γ 1) (b : Γ 0) : QpfProd'.{u} Γ := | |
| ⟨ |
|
Actually, I'm touching these files right now, so I went ahead and committed the suggestions myself, to prevent painful merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51
Also makes
Arrowuniverse-polymorphic.