Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make Prod' universe-polymorphic #52

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Fix: Make Prod' universe-polymorphic #52

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58449e1
fix: make `Prod'` universe-polymorphic
Kiiyya Dec 3, 2024
67e99ac
Make Arrow universe-polymorphic
Kiiyya Dec 3, 2024
48e9236
Merge branch 'main' into fix-Prod-universe-poly
alexkeizer Dec 4, 2024
82b77de
Apply suggestions from code review
alexkeizer Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Qpf/PFunctor/Multivariate/Constructions/Arrow.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ namespace Arrow



def box (f : Arrow' α Γ) : (QpfArrow' α Γ)
:= ⟨(), fun | 0 => f⟩
def box (f : Arrow'.{u} α Γ) : (QpfArrow' α Γ)
:= ⟨⟨⟩, fun | 0 => f⟩

def unbox : QpfArrow' α Γ → Arrow' α Γ
| ⟨_, f⟩ => f 0
Expand All @@ -60,7 +60,7 @@ namespace Arrow
instance : MvFunctor (Arrow' x) where
map f a := unbox <| (ArrowPFunctor x).map f <| box a

instance : MvQPF (Arrow' x) where
instance instMvQPF : MvQPF (Arrow' x) where
P := ArrowPFunctor x
abs := @unbox x
repr := @box x
Expand Down
8 changes: 4 additions & 4 deletions Qpf/PFunctor/Multivariate/Constructions/Prod.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ namespace Prod

open PFin2 (fz fs)

def P : MvPFunctor 2
:= .mk Unit fun _ _ => PFin2 1
def P : MvPFunctor.{u} 2
:= .mk PUnit fun _ _ => PFin2 1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def P : MvPFunctor.{u} 2
:= .mk PUnit fun _ _ => PFin2 1
def P : MvPFunctor.{u} 2 :=
.mk PUnit fun _ _ => PFin2 1

The old formatting is a bit of a mess (my bad 😅), we should probably fix that to use the current standard style (i.e., put := on the same line as the type of the def) as we go along



abbrev QpfProd' := P.Obj
Expand All @@ -30,9 +30,9 @@ abbrev Prod' : TypeFun 2
/--
Constructor for `QpfProd'`
-/
def mk (a : Γ 1) (b : Γ 0) : QpfProd' Γ
def mk (a : Γ 1) (b : Γ 0) : QpfProd'.{u} Γ
:= ⟨
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def mk (a : Γ 1) (b : Γ 0) : QpfProd'.{u} Γ
:= ⟨
def mk (a : Γ 1) (b : Γ 0) : QpfProd'.{u} Γ :=
⟨

(),
⟨⟩,
fun
| 1, _ => a
| 0, _ => b
Expand Down