Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] This PR adds macOS texture support.
The color components are mixed up as RGBA is not supported.
In order to make this work correctly, a few things need to be fixed in the common layer (I will take care of that):
CVPixelBuffer
.Player
implementation doesn't currently support choosing other VLC rendering backends likelibvlc_video_engine_d3d11
(which will be required on Windows later on in order to supportGPUSurfaceTextures
). So there needs to be more flexibility in the rendering part of thePlayer
in general.VideoOutlet
s should be owned by the player which will allow the macOS and Windows plugins to get rid of the outlet map.