-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iOS support #147
Add iOS support #147
Conversation
@jnschulze I've requested you for the review. I didn't know iOS can link libVLC that easy. Seems I should work on Android too. I assume you're busy with your schedule & life. I just wanted to ask if we could just use EDIT: Seems actions are failing. Don't worry I will have a look. |
Thanks a lot for your contribution to the project @krjw-eyev. Really glad to see it working on iOS. |
It's a pleasure! I use it on iPadOS and it works great but I think the UI code of the example probably breaks on iPhone. |
Fixed UI for iPhone |
Yes, I'm quite busy atm, but I should be able to finish the macOS texture stuff soon. I've already refactored the video output handling so it's the responsibility of the platform-specific plugin to attach a "video output" to the actual player now. The Windows-specific implementation also handles resolution changes properly now. See https://github.com/jnschulze/dart_vlc/commits/refactor-video-output-handling-r |
Should I merge this PR before your that PR? I don't think it be causing conflicts to you (or will it)? Thanks for the support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
'CLANG_CXX_LIBRARY' => 'libc++', | ||
} | ||
s.swift_version = '5.0' | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: missing newline ;)
Looks like they're completely independent, so just merge this one. EDIT: too late 😀 |
I have added iOS support. I didn't know how you versioned things so I increased it by one. pubspec.lock is broken since I also changed something in dart_vlc_core. This probably needs changes from you since I don't know how you handle updates.
I hope everything else is fine.