Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS support #147

Merged
merged 6 commits into from
Sep 7, 2021
Merged

Add iOS support #147

merged 6 commits into from
Sep 7, 2021

Conversation

krjw-eyev
Copy link
Collaborator

I have added iOS support. I didn't know how you versioned things so I increased it by one. pubspec.lock is broken since I also changed something in dart_vlc_core. This probably needs changes from you since I don't know how you handle updates.

I hope everything else is fine.

@alexmercerind
Copy link
Owner

@jnschulze I've requested you for the review. I didn't know iOS can link libVLC that easy. Seems I should work on Android too.

I assume you're busy with your schedule & life. I just wanted to ask if we could just use "BGRA" for macOS #122 without having to add additional features of defining the color space etc. It would just be a easy go, I believe most of VideoOutlet etc. is already made by you in that PR.

EDIT: Seems actions are failing. Don't worry I will have a look.

@alexmercerind
Copy link
Owner

alexmercerind commented Sep 7, 2021

Thanks a lot for your contribution to the project @krjw-eyev. Really glad to see it working on iOS.

@krjw-eyev
Copy link
Collaborator Author

It's a pleasure! I use it on iPadOS and it works great but I think the UI code of the example probably breaks on iPhone.

@krjw-eyev
Copy link
Collaborator Author

Fixed UI for iPhone

@jnschulze
Copy link
Collaborator

@jnschulze I've requested you for the review. I didn't know iOS can link libVLC that easy. Seems I should work on Android too.

I assume you're busy with your schedule & life. I just wanted to ask if we could just use "BGRA" for macOS #122 without having to add additional features of defining the color space etc. It would just be a easy go, I believe most of VideoOutlet etc. is already made by you in that PR.

Yes, I'm quite busy atm, but I should be able to finish the macOS texture stuff soon.

I've already refactored the video output handling so it's the responsibility of the platform-specific plugin to attach a "video output" to the actual player now. The Windows-specific implementation also handles resolution changes properly now. See https://github.com/jnschulze/dart_vlc/commits/refactor-video-output-handling-r

@alexmercerind
Copy link
Owner

@jnschulze I've requested you for the review. I didn't know iOS can link libVLC that easy. Seems I should work on Android too.
I assume you're busy with your schedule & life. I just wanted to ask if we could just use "BGRA" for macOS #122 without having to add additional features of defining the color space etc. It would just be a easy go, I believe most of VideoOutlet etc. is already made by you in that PR.

Yes, I'm quite busy atm, but I should be able to finish the macOS texture stuff soon.

I've already refactored the video output handling so it's the responsibility of the platform-specific plugin to attach a "video output" to the actual player now. The Windows-specific implementation also handles resolution changes properly now. See jnschulze/dart_vlc@refactor-video-output-handling-r (commits)

Should I merge this PR before your that PR? I don't think it be causing conflicts to you (or will it)?

Thanks for the support.

Copy link
Collaborator

@jnschulze jnschulze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

'CLANG_CXX_LIBRARY' => 'libc++',
}
s.swift_version = '5.0'
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing newline ;)

@alexmercerind alexmercerind merged commit 2a95c19 into alexmercerind:master Sep 7, 2021
@jnschulze
Copy link
Collaborator

jnschulze commented Sep 7, 2021

@jnschulze I've requested you for the review. I didn't know iOS can link libVLC that easy. Seems I should work on Android too.
I assume you're busy with your schedule & life. I just wanted to ask if we could just use "BGRA" for macOS #122 without having to add additional features of defining the color space etc. It would just be a easy go, I believe most of VideoOutlet etc. is already made by you in that PR.

Yes, I'm quite busy atm, but I should be able to finish the macOS texture stuff soon.
I've already refactored the video output handling so it's the responsibility of the platform-specific plugin to attach a "video output" to the actual player now. The Windows-specific implementation also handles resolution changes properly now. See jnschulze/dart_vlc@refactor-video-output-handling-r (commits)

Should I merge this PR before your that PR? I don't think it be causing conflicts to you (or will it)?

Thanks for the support.

Looks like they're completely independent, so just merge this one.

EDIT: too late 😀

@krjw-eyev krjw-eyev deleted the add-ios branch September 7, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants