forked from argoproj/argo-cd
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appset): make K8s client configurable #8
Draft
alexymantha
wants to merge
77
commits into
master
Choose a base branch
from
configure-qps-burst
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexymantha
changed the title
Configure qps burst
feat(appset): make K8s client configurable
Jun 12, 2024
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Alexy Mantha <alexy@mantha.dev>
alexymantha
force-pushed
the
configure-qps-burst
branch
from
June 12, 2024 20:31
e797ad5
to
e0bc7cf
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
…rgoproj#18629) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
…j#18628) Bumps library/golang from `969349b` to `0f76912`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps bitnami/kubectl from `cdca6c1` to `e704ebf`. --- updated-dependencies: - dependency-name: bitnami/kubectl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#18627) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 125.0.3 to 126.0.0. - [Commits](giggio/node-chromedriver@125.0.3...126.0.0) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
With the Dependabot Node bump in argoproj#18610, the test container no longer builds due to a change in Yarn version. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
…proj#18615) * feat: Support Rollback multi-source apps; Follow-up to PR 14124 Signed-off-by: Keith Chong <kykchong@redhat.com> * Common up code Signed-off-by: Keith Chong <kykchong@redhat.com> --------- Signed-off-by: Keith Chong <kykchong@redhat.com>
* Replaced email to SAMAccountName Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Replaced email to SAMAccountName Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Updated go.mod Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Revert "Updated go.mod" This reverts commit a646653. Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Updated go.mod Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Fixed failing CI Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Fixed failing CI Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Fixed failing CI Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> * Fixed failing CI Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com> --------- Signed-off-by: Raghavi Shirur <rshirur@redhat.com> Signed-off-by: Raghavi Shirur <raghaviss11@gmail.com>
Bumps library/golang from `969349b` to `0f76912`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
* feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * try putting profiles in different directories Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * does this upload the whole directory? Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * create directories and only run one test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * shut everything down before uploading coverage Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * don't fail on goreman failure Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * sleep 30 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * always upload server output Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix: implement graceful shutdown for api server Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Shutdown servers in parallel Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * add noop shutdown function on api server constructor Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix waitgroup Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * more attempts to gracefully shut down Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * cleanup Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * revert graceful shutdown work, needs more work Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more graceful shutdown cleanup Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * lint Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * feat: adding go coverage to e2e tests Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> --------- Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
* chore: enable gocritic linter Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update settings.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update app.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update grpcproxy.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update grpcproxy.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update util.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update server.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update app_management_ns_test.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update app_management_test.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update path_traversal.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update sessionmanager.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update .golangci.yaml Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
…roj#17588) (argoproj#17890) Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
…argoproj#18649) Bumps [SonarSource/sonarqube-scan-action](https://github.com/sonarsource/sonarqube-scan-action) from 2.1.0 to 2.2. - [Release notes](https://github.com/sonarsource/sonarqube-scan-action/releases) - [Commits](SonarSource/sonarqube-scan-action@86fe817...540792c) --- updated-dependencies: - dependency-name: SonarSource/sonarqube-scan-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…j#18650) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.4.1 to 4.5.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@125fc84...e28ff12) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
* minor fixes Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: remove double import Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* docs: Fix whitespace around after open paren in FAQ Signed-off-by: Josh Soref <jsoref@gmail.com> * docs: Fix trailing whitespace Signed-off-by: Josh Soref <jsoref@gmail.com> * docs: Fix grammar in FAQ wrt redis auth Signed-off-by: Josh Soref <jsoref@gmail.com> * docs: Fix FAQ markdown for turning off redis auth Signed-off-by: Josh Soref <jsoref@gmail.com> * docs: Start talking about manifest generation Signed-off-by: Josh Soref <jsoref@gmail.com> --------- Signed-off-by: Josh Soref <jsoref@gmail.com>
* dropdown-fixed Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * removed-extra-css Signed-off-by: Surajyadav <harrypotter1108@gmail.com> --------- Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
argoproj#18656) Bumps library/node from `f73cc32` to `5e4044f`. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…18654) Bumps library/node from `f73cc32` to `5e4044f`. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps library/node from `f73cc32` to `5e4044f`. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps library/golang from `0f76912` to `a1dc408`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…j#18655) Bumps library/golang from `0f76912` to `a1dc408`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#18691) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
…set folder (argoproj#18689) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
…folder (argoproj#18690) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
…oj#18160) * Add labels on Application's k8s events Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix typo Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Add new cm keys & doc Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix typo Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * correct rebase changes Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix linting Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
…ver folders (argoproj#18702) * chore: enable require-error from testifylint on cmpserver and reposerver folders Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update app_k8s_events_test.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> Signed-off-by: root <root@daocloud.io>
* fix: JSON unmarshaling error handling and nil return in ExecuteHealthLua function Signed-off-by: Yonatan Sasson <yonatanxd7@gmail.com> * Update util/lua/lua.go Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yonatan Sasson <yonatanxd7@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
…j#18704) Bumps library/golang from `4950c1c` to `c2010b9`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…argoproj#18705) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.14.2 to 20.14.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps library/golang from `4950c1c` to `c2010b9`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps library/redis from `f5ef9e2` to `e422889`. --- updated-dependencies: - dependency-name: library/redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ws](https://github.com/websockets/ws) from 8.17.0 to 8.17.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.17.0...8.17.1) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ws](https://github.com/websockets/ws) from 8.17.0 to 8.17.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.17.0...8.17.1) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
…roj#18708) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.4.0 to 6.0.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@ca052bb...c382f71) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…) (argoproj#16781) * feat(cli): add cmd to preview generated apps Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix build Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix local proto gen Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * dry run client Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix: allow to run codegen outside GOPATH Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * clientgen Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * openapigen Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * remove ensure-gopath Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix tests and templatePatch Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix build Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * convert to interfaces Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * codegen Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * extract common code Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * use appset params in server Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * codegen Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix test build Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * unit tests Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * move test to new package Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * move to correct folders Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * fix build Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * review Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * lint Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix lint Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * auto generate mocks Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * better error handling Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more docs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more docs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * lint Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…ts (argoproj#18718) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Bump version in master Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update SECURITY-INSIGHTS.yml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: ishitasequeira <46771830+ishitasequeira@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
There are some situations where the project will be `undefined`. When that happens, attempting to delete a repo won't be possible, since the backend will be looking for a project with the literal name `undefined`. To fix this, set an empty string for `undefined|null` values. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: tillepille <github@tillepille.io>
…rgoproj#18739) Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 126.0.1 to 126.0.2. - [Commits](giggio/node-chromedriver@126.0.1...126.0.2) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…argoproj#18738) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.14.4 to 20.14.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Toni Grabulosa <71640433+toniGrabulosa@users.noreply.github.com>
…argoproj#18750) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.14.6 to 20.14.7. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roj#18749) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.0.0 to 6.0.2. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@c382f71...f6010ea) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way to tweak the Kubernetes client configuration for the
applicationset-controller
, it defaults to the values set incontroller-runtime
:https://github.com/kubernetes-sigs/controller-runtime/blob/1f5b39fa59d15fae78e521c9c9f2acabbbb3ea17/pkg/client/config/config.go#L101-L106
which are pretty low.
We use the ApplicationSet controller with the cluster generators pretty heavily which means we call
ListClusters
very frequently and we started to get throttled by the client. It was causing the ApplicationSet controller to not be able to process the ApplicationSets fast enough due to the limit of default limit of 30 QPS which caused the queue to slowly build up over time and the ApplicationSet controller was never able to catch up.Using this PR, I was able to increase the rate limits and fix the performance issues we were having:
For consistency, I think it makes sense to apply the same default client config to the ApplicationSet controller that is applied to the Application controller.
Here is the diff in the client config when applying the same default as the Application Controller:
This has been running on our ArgoCD instance for almost a week without any issues.
Checklist: