This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 46
isRefined is not checking if the attribute has a numeric refinement #110
Comments
Well I think hasRefinement would be a better candidate to get if an attribute has any kind of numeric refinement. isRefined has more parameters which are not consistent between facets and numeric filters. |
@redox what do you mean? |
Sorry, I meant currently |
bobylito
added a commit
that referenced
this issue
Jun 26, 2015
FIX #110 : provide a way to test if an attribute is numerically defined
bobylito
pushed a commit
that referenced
this issue
Jun 29, 2015
* FIX : #113 support for attributes hightlightPreTag and hightlighPostTag * FIX : #112 distinct = undefined sent to the server * FIX : #110 helper.hasRefinements() now checks for numerics * FIX : #106 convert refinements to string * DOC : Update theme + fix (github.com/algolia/minami) * DOC : Fix misc links and descrition and added samples of objects * DOC : Added a cheat sheet in the generated documentation
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this issue
Jul 10, 2023
… attribute is numerically defined
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this issue
Jul 10, 2023
…ix/110 FIX algolia/algoliasearch-helper-js#110 : provide a way to test if an attribute is numerically defined
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this issue
Jul 10, 2023
* FIX : algolia/algoliasearch-helper-js#113 support for attributes hightlightPreTag and hightlighPostTag * FIX : algolia/algoliasearch-helper-js#112 distinct = undefined sent to the server * FIX : algolia/algoliasearch-helper-js#110 helper.hasRefinements() now checks for numerics * FIX : algolia/algoliasearch-helper-js#106 convert refinements to string * DOC : Update theme + fix (github.com/algolia/minami) * DOC : Fix misc links and descrition and added samples of objects * DOC : Added a cheat sheet in the generated documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
isRefined
is checking if it a facet or disjunctive facet has a refinement; we should also check it it's an attribute with a numerical refinement.The text was updated successfully, but these errors were encountered: