Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

distinct=undefined is sent to the API if distinct is not set #112

Closed
redox opened this issue Jun 21, 2015 · 2 comments
Closed

distinct=undefined is sent to the API if distinct is not set #112

redox opened this issue Jun 21, 2015 · 2 comments
Assignees
@bobylito
Labels
Type: Bug
Milestone
2.1.2

Comments

@redox
Copy link
Contributor

redox commented Jun 21, 2015

distinct=undefined is sent to the API if distinct is not set, generating a 400 error.
@bobylito bobylito self-assigned this Jun 21, 2015
@bobylito bobylito added this to the 2.1.2 milestone Jun 21, 2015
@bobylito
Copy link
Contributor

Can't reproduce, maybe related to 2.1.0 and fixed in 2.1.1.

@bobylito bobylito reopened this Jun 22, 2015
@bobylito
Copy link
Contributor

I just reproduced this bug. Working on it!

bobylito pushed a commit that referenced this issue Jun 23, 2015
Modify distinct test to check the #112
0b30a5e
bobylito added a commit that referenced this issue Jun 23, 2015
@bobylito
Merge pull request #115 from algolia/fix/112
e393120 
Fix #112 : do not set undefined to distinct in the request.
bobylito pushed a commit that referenced this issue Jun 29, 2015
2.1.2 - 2015-06-26
7a30e14 
  * FIX : #113 support for attributes hightlightPreTag and hightlighPostTag
  * FIX : #112 distinct = undefined sent to the server
  * FIX : #110 helper.hasRefinements() now checks for numerics
  * FIX : #106 convert refinements to string
  * DOC : Update theme + fix (github.com/algolia/minami)
  * DOC : Fix misc links and descrition and added samples of objects
  * DOC : Added a cheat sheet in the generated documentation
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
FIX algolia/algoliasearch-helper-js#112 Only apply distinct when it's…
edae6d9 
… necessary
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
Modify distinct test to check the algolia/algoliasearch-helper-js#112
7471b00
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
@bobylito
Merge pull request algolia/algoliasearch-helper-js#115 from algolia/f…
dccb449 
…ix/112

Fix algolia/algoliasearch-helper-js#112 : do not set undefined to distinct in the request.
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
2.1.2 - 2015-06-26
5488827 
  * FIX : algolia/algoliasearch-helper-js#113 support for attributes hightlightPreTag and hightlighPostTag
  * FIX : algolia/algoliasearch-helper-js#112 distinct = undefined sent to the server
  * FIX : algolia/algoliasearch-helper-js#110 helper.hasRefinements() now checks for numerics
  * FIX : algolia/algoliasearch-helper-js#106 convert refinements to string
  * DOC : Update theme + fix (github.com/algolia/minami)
  * DOC : Fix misc links and descrition and added samples of objects
  * DOC : Added a cheat sheet in the generated documentation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bobylito bobylito

Labels
Type: Bug
Projects
None yet
Milestone
2.1.2
Development

No branches or pull requests
2 participants
@redox @bobylito