Handling tags in the helper?

[bobylito]

We have an API to handle the tags. Right now, it's very bare bone (use of the most level apis, string based...). At the very least, we should have an API that provides a basic add/remove/list the tags used for filtering :

helper.addTag( "tag" );
helper.removeTag( "tag" );
helper.listTags() // []

[redox]

I would go for addTagRefinement, removeTagRefinement (getRefinements or getTagRefinements) then because it's exactly like the facets & numerics.

[pixelastic]

I agree to keep the consistency with a set of *Refinement methods. Maybe
a clearTags also, to remove them all.

On Tue, Jun 2, 2015 at 10:20 PM, Sylvain Utard notifications@github.com
wrote:

I would go for addTagRefinement, removeTagRefinement (getRefinements or
getTagRefinements) then because it's exactly like the facets & numerics.

—
Reply to this email directly or view it on GitHub
#91 (comment)
.

[redox]

So maybe here I would see the same logic than getRefinements(attribute) -> what about clearRefinements(attribute):

clearRefinements("_tags");
clearRefinements("my_facet_attribute");
clearRefinements("my_numeric_attribute");

Maybe that's only sugar in the AlgoliaSearchHelper on top of 4 clearTagRefinements(), clearFacetRefinements(facet), clearDisjunctiveFacetRefinements(facet) and clearNumericalRefinements(attribute) of the SearchParameters.

[bobylito]

Not sure about the clearRefinements(_tags), i don't feel like it would be obvious for users that this is the attribute of the _tags because we don't have to specify it when manipulating tags.