Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade preact-compat #2751

Closed
wants to merge 1 commit into from
Closed

Upgrade preact-compat #2751

wants to merge 1 commit into from

Conversation

bronzehedwick
Copy link
Contributor

Summary

Updrading preact-compat fixes IE 11 + Google Maps clashing. My previous commit (see below) did not address the issue in the preact-compat library, which is also effecting. Upgrading the library resolves this.

Result

@algobot
Copy link
Contributor

algobot commented Feb 26, 2018

Deploy preview for algolia-instantsearch ready!

Built with commit 0a8ca38

https://deploy-preview-2751--algolia-instantsearch.netlify.com

@bronzehedwick
Copy link
Contributor Author

Folks responding to #2749 were correct: I was confused about where the error was actually coming from. While the Symbol checks in instantsearch might have also caused a problem, the real issue was the checks in preact-compat, which the mentioned PR resolves.

My apologies for my wrongness.

@bobylito
Copy link
Contributor

Hi @bronzehedwick thanks for opening this PR and for taking the time to contribute. However we can't upgrade to this version because it breaks the slider (https://deploy-preview-2751--algolia-instantsearch.netlify.com/v2/dev-novel/?selectedStory=RangeSlider.default) I haven't had time to investigate this specific issue even though encountered it when trying to upgrade the preact-compat lib too.

@bronzehedwick
Copy link
Contributor Author

Ah ok, that's a bummer. I think we're going to go ahead with a fork for now, since we're not using the slider and we'd like to release this coming Tuesday. We can switch back to reference the upstream code once the issues have been worked through.

Thanks so much for your help!

@bobylito
Copy link
Contributor

bobylito commented Feb 28, 2018

Sorry about that @bronzehedwick Going with your own fork might be the best for now indeed. Closing this PR for now. Will update when we have a fix.

@bobylito bobylito closed this Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants