IE11 seems to define Symbol but without the method 'for' #423
Conversation
|
@developit If you don't mind, could you release a version with this patch included? Thank you! |
|
There might be something else in here because Symbol is not at all supported in IE11: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol#Browser_compatibility We have been facing the same issue and it might just come from a polyfill that defines only part of Symbol. |
|
Quick update on this, for reference, IE11 does not have window.Symbol at all. But anyone using babel-polyfill (https://babeljs.io/docs/usage/polyfill/), will have a sub-complete Symbol being defined, without Symbol.for. So this current PR really fixes preact-compat compatibility with babel-polyfill, not IE11. It's a side effect that it fixes IE11. Still, it's a valid fix. Any way we can get a release of preact-compat @developit, pleeeease? :) |
|
Thanks for clarifying !
…On Thu, Oct 19, 2017 at 10:28 AM Vincent Voyer ***@***.***> wrote:
Quick update on this, for reference, IE11 does not have window.Symbol at
all. But anyone using babel-polyfill (
https://babeljs.io/docs/usage/polyfill/), will have a sub-complete Symbol
being defined, without Symbol.for.
So this current PR really fixes preact-compat compatibility with
babel-polyfill, not IE11. It's a side effect that it fixes IE11.
Still, it's a valid fix.
Any way we can get a release of preact-compat @developit
<https://github.com/developit>, pleeeease? :) npm run release?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#423 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAiskNSqC-LwQorAW1eO6t_KnNQlgBZpks5stwgggaJpZM4PXRfO>
.
|
|
Yup, I'll get something out today or tomorrow. Sorry for the slows! |
1. make sure `preact-compat` is at a version which supports IE11 fixes https://github.com/algolia/algoliasearch-magento-2/issues/535 See for more information also preactjs/preact-compat#423, which is the original fix of the bug 2. make sure there's no duplicate dependency versions by using Yarn resolutions NOTE: you can only use Yarn now to build, not npm.
1. make sure `preact-compat` is at a version which supports IE11 fixes https://github.com/algolia/algoliasearch-magento-2/issues/535 See for more information also preactjs/preact-compat#423, which is the original fix of the bug 2. make sure there's no duplicate dependency versions by using Yarn resolutions NOTE: you can only use Yarn now to build, not npm.
Fixes:
"Object does not support the method for" error in IE11.