This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(hooks): migrate to useSyncExternalStore()
#3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6e755ce:
|
✅ Deploy Preview for react-instantsearch ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Haroenv
reviewed
May 31, 2022
Co-authored-by: Haroen Viaene <hello@haroen.me>
Haroenv
approved these changes
Jun 1, 2022
This was referenced Jun 3, 2022
This was referenced Jun 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the implementation in
<InstantSearch>from an effect to theuseSyncExternalStore()API. This Hook is meant to support new concurrent and time slicing features of React 18.This is using a shim that backports the behavior to all React versions from 16.8.0 (the one that provides Hooks).
Together with algolia/instantsearch#5056, we should have the certainty to support concurrent features with a minimum amount of network requests.
Related