This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(connectInfiniteHits): always set a value for previous page #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit 509a530 https://deploy-preview-1195--react-instantsearch.netlify.com |
samouss
changed the title
Haroenv
approved these changes
Apr 27, 2018
samouss
force-pushed
the
fix/infinite-hits
branch
from
d322edc
to
d300ed4
Compare
samouss
force-pushed
the
fix/infinite-hits
branch
from
d300ed4
to
509a530
Compare
samouss
added a commit
that referenced
this pull request
May 28, 2018
<a name="5.1.0"></a> # [5.1.0](v5.0.3...v5.1.0) (2018-05-28) ### Bug Fixes * **connectInfiniteHits:** always set a value for previous page ([#1195](#1195)) ([4c218d5](4c218d5)) * **indexUtils:** avoid throw an error on cleanUp multi indices ([#1265](#1265)) ([12f5ace](12f5ace)) ### Features * **searchClient:** Add support for custom Search Clients ([#1216](#1216)) ([174cc28](174cc28))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the
connectInfinteHitsconnector to render an empty array when the previous page is not defined. When it'sundefinedall the tests regarding the page will fail because we compare a number withundefinedand it's alwaysfalse.Before
After
You can also test it live: