test: add testcases for CompareRequest&Response #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uncle-Justice
requested review from
Xunzhuo,
2456868764 and
CH3CHO
as code owners
Uncle-Justice
changed the title
|
LGTM |
johnlanni
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
#733 的补充
CompareRequest和CompareResponse增加单元测试用例，验证e2e框架支持对四种Content-Type的body的校验能力form-data类型时，通常会在后面跟一个boudary的数据，在header中实际应为（举例）:"ContentType": "multipart/form-data; boundary=----WebKitFormBoundaryAnydWsQ1ajKuGoCd"，为此body类型补充了一些检查逻辑CompareRequest&Response中的一些报错输出存在一些bug，比如对于body数据结构的类型断言失败时，不应打印body内容，因为类型未知。Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
本地运行UT通过
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews