-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: higress global configmap support config route timeout #883
feat: higress global configmap support config route timeout #883
Conversation
可否签署一下CLA,以便观察CI是否通过 |
TODO : need rebase after the PR merged. |
@alexzzh please resolve the conflicts. |
49f8bb0
to
ecead7d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
==========================================
- Coverage 38.14% 38.01% -0.13%
==========================================
Files 61 61
Lines 10442 10474 +32
==========================================
- Hits 3983 3982 -1
- Misses 6160 6192 +32
- Partials 299 300 +1
|
@johnlanni Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
pass