Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: higress global configmap support config route timeout #883

Merged

Conversation

alexzzh
Copy link
Collaborator

@alexzzh alexzzh commented Mar 27, 2024

Ⅰ. Describe what this PR did

  • higress 全局配置支持配置route级别timeout
    • 默认route的timeout为0,不改变原来的效果
  • 对应的参数说明文档 PR

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

  • 已添加e2e测试用例

Ⅳ. Describe how to verify it

  • 运行e2e测试,ConfigMapGlobalEnvoy 测试用例全部pass
    • make run-higress-e2e-test
    --- PASS: TestHigressConformanceTests (261.38s)
    --- PASS: TestHigressConformanceTests/ConfigMapGlobalEnvoy (245.93s)
       --- PASS: TestHigressConformanceTests/ConfigMapGlobalEnvoy/ConfigMap_Global_Envoy (245.92s)
    --- SKIP: TestHigressConformanceTests/ConfigmapGzip (0.00s)
    --- PASS: TestHigressConformanceTests/ConfigMapGzipEnvoy (13.10s)
       --- PASS: TestHigressConformanceTests/ConfigMapGzipEnvoy/ConfigMap_Gzip_Envoy (13.08s)
    
    PASS
    ok      command-line-arguments  262.245s
    

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

@alexzzh alexzzh changed the title higress global configmap support config route timeout feat: higress global configmap support config route timeout Mar 27, 2024
@sjcsjc123
Copy link
Collaborator

可否签署一下CLA,以便观察CI是否通过

@alexzzh
Copy link
Collaborator Author

alexzzh commented Mar 29, 2024

TODO : need rebase after the PR merged.

@johnlanni
Copy link
Collaborator

@alexzzh please resolve the conflicts.

@alexzzh alexzzh force-pushed the feature-global-config-support-route-timeout branch from 49f8bb0 to ecead7d Compare April 2, 2024 10:39
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 5.88235% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 38.01%. Comparing base (b4f72d3) to head (ecead7d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #883      +/-   ##
==========================================
- Coverage   38.14%   38.01%   -0.13%     
==========================================
  Files          61       61              
  Lines       10442    10474      +32     
==========================================
- Hits         3983     3982       -1     
- Misses       6160     6192      +32     
- Partials      299      300       +1     
Files Coverage Δ
pkg/ingress/kube/configmap/global.go 27.53% <5.88%> (-1.66%) ⬇️

... and 1 file with indirect coverage changes

@alexzzh
Copy link
Collaborator Author

alexzzh commented Apr 2, 2024

@alexzzh please resolve the conflicts.

@johnlanni Done!

@johnlanni
Copy link
Collaborator

@alexzzh There is a risk in configuring the global route timeout, which may cause issues with websocket routing. It needs to be mentioned in the documentation. Can you help me submit a pull request for the document? Let's review it together.

@alexzzh
Copy link
Collaborator Author

alexzzh commented Apr 3, 2024

@alexzzh There is a risk in configuring the global route timeout, which may cause issues with websocket routing. It needs to be mentioned in the documentation. Can you help me submit a pull request for the document? Let's review it together.

please review this PR.
thanks very much.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 6c7b175 into alibaba:main Apr 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants