optimize on construct envoyfilter #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexzzh
commented
Mar 27, 2024
alexzzh
commented
Mar 27, 2024
alexzzh
commented
Mar 27, 2024
| } | ||
|
|
||
| upstreamStruct := g.constructUpstream(global.Upstream) | ||
| bufferLimitStruct = g.constructUpstreamBufferLimit(global.Upstream) | ||
| if len(upstreamStruct) == 0 { |
There was a problem hiding this comment.
3 为什么 Upstream 为空会影响到 BufferLimit 的envoyfilter的构建?
2456868764
reviewed
Mar 28, 2024
|
LGTM |
johnlanni
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
- Coverage 38.12% 38.02% -0.11%
==========================================
Files 61 61
Lines 10438 10440 +2
==========================================
- Hits 3980 3970 -10
- Misses 6158 6169 +11
- Partials 300 301 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #890
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
passⅤ. Special notes for reviews