-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize on construct envoyfilter #889
optimize on construct envoyfilter #889
Conversation
} | ||
|
||
upstreamStruct := g.constructUpstream(global.Upstream) | ||
bufferLimitStruct = g.constructUpstreamBufferLimit(global.Upstream) | ||
if len(upstreamStruct) == 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 为什么 Upstream 为空会影响到 BufferLimit 的envoyfilter的构建?
LGTM |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
- Coverage 38.12% 38.02% -0.11%
==========================================
Files 61 61
Lines 10438 10440 +2
==========================================
- Hits 3980 3970 -10
- Misses 6158 6169 +11
- Partials 300 301 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #890
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
pass
Ⅴ. Special notes for reviews