Skip to content

Commit

Permalink
Use async appender to print log for nacos-client. (#10085)
Browse files Browse the repository at this point in the history
  • Loading branch information
KomachiSion authored Mar 13, 2023
1 parent bff133f commit 34a29e7
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 12 deletions.
23 changes: 16 additions & 7 deletions client/src/main/resources/nacos-log4j2.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@
</DefaultRolloverStrategy>
</RollingFile>

<Async name="ASYNC_CONFIG" bufferSize="1024" blocking="false">
<AppenderRef ref="CONFIG_LOG_FILE"/>
</Async>

<RollingFile name="REMOTE_LOG_FILE" fileName="${logPath}/nacos/remote.log"
filePattern="${logPath}/nacos/remote.log.%d{yyyy-MM-dd}.%i">
<PatternLayout>
Expand All @@ -58,6 +62,10 @@
</Delete>
</DefaultRolloverStrategy>
</RollingFile>

<Async name="ASYNC_REMOTE" bufferSize="1024" blocking="false">
<AppenderRef ref="REMOTE_LOG_FILE"/>
</Async>

<RollingFile name="NAMING_LOG_FILE" fileName="${logPath}/nacos/naming.log"
filePattern="${logPath}/nacos/naming.log.%d{yyyy-MM-dd}.%i">
Expand All @@ -78,30 +86,31 @@
</DefaultRolloverStrategy>

</RollingFile>

<Async name="ASYNC_NAMING" bufferSize="1024" blocking="false">
<AppenderRef ref="NAMING_LOG_FILE"/>
</Async>
</Appenders>

<Loggers>
<Logger name="com.alibaba.nacos.client" level="${nacosClientProperty:com.alibaba.nacos.config.log.level:-info}"
additivity="false">
<AppenderRef ref="CONFIG_LOG_FILE"/>
<AppenderRef ref="ASYNC_CONFIG"/>
</Logger>

<Logger name="com.alibaba.nacos.common.remote.client" level="${nacosClientProperty:com.alibaba.nacos.config.log.level:-info}"
additivity="false">
<AppenderRef ref="REMOTE_LOG_FILE"/>
<AppenderRef ref="ASYNC_REMOTE"/>
</Logger>

<Logger name="com.alibaba.nacos.client.config" level="${nacosClientProperty:com.alibaba.nacos.config.log.level:-info}"
additivity="false">
<AppenderRef ref="CONFIG_LOG_FILE"/>
<AppenderRef ref="ASYNC_CONFIG"/>
</Logger>

<Logger name="com.alibaba.nacos.client.naming" level="${nacosClientProperty:com.alibaba.nacos.naming.log.level:-info}"
additivity="false">
<AppenderRef ref="NAMING_LOG_FILE"/>
<AppenderRef ref="ASYNC_NAMING"/>
</Logger>
<Root level="INFO">
<AppenderRef ref="CONFIG_LOG_FILE"/>
</Root>
</Loggers>
</Configuration>
30 changes: 25 additions & 5 deletions client/src/main/resources/nacos-logback.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@
</encoder>
</appender>

<appender name="ASYNC-CONFIG" class="ch.qos.logback.classic.AsyncAppender">
<discardingThreshold>0</discardingThreshold>
<queueSize>1024</queueSize>
<neverBlock>true</neverBlock>
<appender-ref ref="CONFIG_LOG_FILE"/>
</appender>

<appender name="NAMING_LOG_FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
<file>${logPath}/nacos/naming.log</file>

Expand All @@ -56,6 +63,13 @@
</encoder>
</appender>

<appender name="ASYNC-NAMING" class="ch.qos.logback.classic.AsyncAppender">
<discardingThreshold>0</discardingThreshold>
<queueSize>1024</queueSize>
<neverBlock>true</neverBlock>
<appender-ref ref="NAMING_LOG_FILE"/>
</appender>

<appender name="REMOTE_LOG_FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
<file>${logPath}/nacos/remote.log</file>

Expand All @@ -73,31 +87,37 @@
</encoder>
</appender>

<appender name="ASYNC-REMOTE" class="ch.qos.logback.classic.AsyncAppender">
<discardingThreshold>0</discardingThreshold>
<queueSize>1024</queueSize>
<neverBlock>true</neverBlock>
<appender-ref ref="REMOTE_LOG_FILE"/>
</appender>

<logger name="com.alibaba.nacos.client" level="${nacosConfigLogLevel}"
additivity="false">
<appender-ref ref="CONFIG_LOG_FILE"/>
<appender-ref ref="ASYNC-CONFIG"/>
</logger>


<Logger name="com.alibaba.nacos.common.remote.client" level="${nacosConfigLogLevel}"
additivity="false">
<appender-ref ref="REMOTE_LOG_FILE"/>
<appender-ref ref="ASYNC-REMOTE"/>
</Logger>

<Logger name="com.alibaba.nacos.shaded.io.grpc" level="${nacosConfigLogLevel}"
additivity="false">
<appender-ref ref="REMOTE_LOG_FILE"/>
<appender-ref ref="ASYNC-REMOTE"/>
</Logger>

<logger name="com.alibaba.nacos.client.config" level="${nacosConfigLogLevel}"
additivity="false">
<appender-ref ref="CONFIG_LOG_FILE"/>
<appender-ref ref="ASYNC-CONFIG"/>
</logger>

<logger name="com.alibaba.nacos.client.naming" level="${nacosConfigLogLevel}"
additivity="false">
<appender-ref ref="NAMING_LOG_FILE"/>
<appender-ref ref="ASYNC-NAMING"/>
</logger>

</configuration>

0 comments on commit 34a29e7

Please sign in to comment.