Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#10084] Use async appender to print log for nacos-client. #10085

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fixes #10084

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #10085 (4995f16) into develop (1968b3f) will increase coverage by 50.84%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             develop   #10085       +/-   ##
==============================================
+ Coverage           0   50.84%   +50.84%     
- Complexity         0     4882     +4882     
==============================================
  Files              0      865      +865     
  Lines              0    27459    +27459     
  Branches           0     3031     +3031     
==============================================
+ Hits               0    13961    +13961     
- Misses             0    12280    +12280     
- Partials           0     1218     +1218     

see 865 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1968b3f...4995f16. Read the comment docs.

@KomachiSion KomachiSion merged commit 34a29e7 into alibaba:develop Mar 13, 2023
@KomachiSion KomachiSion deleted the develop-async-log branch March 14, 2023 01:38
KomachiSion added a commit that referenced this pull request Mar 14, 2023
* Use async appender to print log for nacos-client.

* [ISSUE#10062] Naming support aliyun STS auth.

* For checkstyle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhance] Client async log.
2 participants