Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize nacos default application.properties configuration #10206

Closed
yuyijq opened this issue Mar 28, 2023 · 2 comments
Closed

Optimize nacos default application.properties configuration #10206

yuyijq opened this issue Mar 28, 2023 · 2 comments
Labels
contribution welcome

Comments

@yuyijq
Copy link
Contributor

yuyijq commented Mar 28, 2023

我们在实际运维nacos集群的时候发现几个跟默认配置相关的问题，这些问题都是碰到实际问题的时候才发现的，如果nacos默认的配置文件就能解决就更好了：

  1. Nacos里的监控指标默认没有暴露
  2. 我们是通过SLB访问Nacos集群，SLB需要healthcheck，默认未暴露
  3. springboot tomcat新的版本里默认关闭了tomcat的mbean，导致收集不到tomcat的指标，而这些指标对于nacos集群健康状况很重要
  4. nacos的tomcat access log日志量非常大，默认是按照天切割，而access log又没有按照大小切割的方式，所以最好改成每小时滚动一次。
@KomachiSion
Copy link
Collaborator

  1. 不能默认打开，会被质疑有数据泄漏风险（即使是监控数据也是数据，安全不和你讲道理）。
  2. 同理
  3. 4可以提一个PR改动下。

@stone-98 stone-98 mentioned this issue Apr 1, 2023
Closed
5 tasks
KomachiSion pushed a commit that referenced this issue Apr 3, 2023
@yuyijq
[ISSUE #10206] Optimize nacos default application.properties configur…
dcb1017 
…ation (#10207)

* Optimize nacos default application.properties configuration:
1. expose prometheus endpoint for metrics.
2. expose health endpoint for SLB healthcheck.
3. switch on mbean for tomcat, so we can collect tomcat metrics.
4. use one file per hour for tomcat access log

* comment prometheus and health endpoint

* enable rotate
@KomachiSion
Copy link
Collaborator

Closed by #10207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuyijq @KomachiSion