Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #10206] Optimize nacos default application.properties configuration #10207

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

yuyijq
Copy link
Contributor

@yuyijq yuyijq commented Mar 28, 2023

  1. expose prometheus endpoint for metrics.
  2. expose health endpoint for SLB healthcheck.
  3. switch on mbean for tomcat, so we can collect tomcat metrics.
  4. use one file per hour for tomcat access log

1. expose prometheus endpoint for metrics.
2. expose health endpoint for SLB healthcheck.
3. switch on mbean for tomcat, so we can collect tomcat metrics.
4. use one file per hour for tomcat access log

#*************** Metrics Related Configurations ***************#
### Metrics for prometheus
#management.endpoints.web.exposure.include=*
management.endpoints.web.exposure.include=prometheus,health
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't default open.

Some orgnization or security engineer think the data will leak.

@yuyijq yuyijq requested a review from KomachiSion April 2, 2023 13:47
@codecov-commenter
Copy link

Codecov Report

Merging #10207 (ff722ae) into develop (953fa9e) will increase coverage by 0.53%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10207      +/-   ##
=============================================
+ Coverage      51.86%   52.39%   +0.53%     
- Complexity      5098     5169      +71     
=============================================
  Files            875      874       -1     
  Lines          27791    27756      -35     
  Branches        3077     3073       -4     
=============================================
+ Hits           14414    14544     +130     
+ Misses         12043    11889     -154     
+ Partials        1334     1323      -11     

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953fa9e...ff722ae. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants