-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] The new implement of Selector in Nacos 2.0. #6301
Labels
Comments
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Jul 12, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Jul 14, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Jul 14, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Jul 14, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Jul 14, 2021
This was referenced Jul 14, 2021
KomachiSion
pushed a commit
that referenced
this issue
Jul 16, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Jul 16, 2021
…e the 1.x LabelSelector logic to CmdbLabelSelector and add unit test.
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Jul 19, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Jul 19, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Jul 19, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Jul 29, 2021
…the add and select of Selector.
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 4, 2021
… feature-alibaba#6301-integrate
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 4, 2021
…lement of NoneSelector.
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 4, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 4, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 4, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 4, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 5, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 5, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 5, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 5, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 5, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 5, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 6, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 8, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 9, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 9, 2021
… feature-alibaba#6301-integrate � Conflicts: � console/src/main/resources/static/js/main.js
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 9, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 9, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 9, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 9, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 10, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 10, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 13, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 13, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 16, 2021
Merged
5 tasks
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 17, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 17, 2021
KomachiSion
pushed a commit
that referenced
this issue
Aug 18, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 18, 2021
…ort custom selector config.
5 tasks
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Aug 20, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Sep 2, 2021
…tps://github.com/brotherlu-xcq/nacos into feature-alibaba#6301-integrate-3 � Conflicts: � naming/src/main/java/com/alibaba/nacos/naming/push/v2/task/PushExecuteTask.java
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Sep 2, 2021
brotherlu-xcq
added a commit
to brotherlu-xcq/nacos
that referenced
this issue
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The old implement of Selector in Nacos 1.x just a simple and inflexible implement, cannot extend by user self. when we have another scene, we must integrate the new function to Nacos, it's not a good idea. you can find in the issue #5612 .
So in Nacos 2.0, we want to introduce an new Implement of Selector to make the Selector more flexible and friendly for users.
Describe the solution you'd like
We will make the Selector as two part for user which can be implement by their self if they need. one is still
![image](https://user-images.githubusercontent.com/25661357/124712896-7210e200-df32-11eb-8a24-17033c6a2b89.png)
Selector
which only provide select instances logic, another isSelectContextBuilder
which provide the context used bySelector
. the main work flow of new implement like below.you can find more detail description in detail design.
We split the whole feature as parts like below:
Selector
,SelectorManager
,SelectorContextBuilder
and add unit test for the workflowLableSelecotr
,CMDBSelectoerContextBuilder
, which can match the most scene and the implement in Nacos 1.x, Add unit test for the built-in implementDescribe alternatives you've considered
No
Additional context
No
The text was updated successfully, but these errors were encountered: