Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] The new implement of Selector in Nacos 2.0. #6301

Closed
brotherlu-xcq opened this issue Jul 7, 2021 · 0 comments
Closed

[Feature] The new implement of Selector in Nacos 2.0. #6301

brotherlu-xcq opened this issue Jul 7, 2021 · 0 comments

Comments

@brotherlu-xcq
Copy link
Collaborator

brotherlu-xcq commented Jul 7, 2021

Is your feature request related to a problem? Please describe.

The old implement of Selector in Nacos 1.x just a simple and inflexible implement, cannot extend by user self. when we have another scene, we must integrate the new function to Nacos, it's not a good idea. you can find in the issue #5612 .

So in Nacos 2.0, we want to introduce an new Implement of Selector to make the Selector more flexible and friendly for users.

Describe the solution you'd like

We will make the Selector as two part for user which can be implement by their self if they need. one is still Selector which only provide select instances logic, another is SelectContextBuilder which provide the context used by Selector. the main work flow of new implement like below.
image

you can find more detail description in detail design.

We split the whole feature as parts like below:

part description sub issue assign status
1 Define the workflow, include Selector, SelectorManager, SelectorContextBuilder and add unit test for the workflow #6356 @brotherlu-xcq done
2 Implement the built-in LableSelecotr, CMDBSelectoerContextBuilder, which can match the most scene and the implement in Nacos 1.x, Add unit test for the built-in implement #6365 @brotherlu-xcq done
3 Integrate this workflow to Nacos 2.0, including all sence like Grpc, Http and add unit test. #6430 @brotherlu-xcq done
4 add the use example @brotherlu-xcq
5 add the use document @brotherlu-xcq

Describe alternatives you've considered
No

Additional context
No

brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 12, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 14, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 14, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 14, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 14, 2021
KomachiSion pushed a commit that referenced this issue Jul 16, 2021
* [ISSUE #6301] Define the workflow of Selector.

* [ISSUE #6301] Add unit test for SelectorManager.

* [ISSUE #6301] fix ci issue.

* [ISSUE #6301] test Selector with serial.

* [ISSUE #6301] fix javadoc.
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 16, 2021
…e the 1.x LabelSelector logic to CmdbLabelSelector and add unit test.
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 19, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 19, 2021
KomachiSion pushed a commit that referenced this issue Jul 20, 2021
…it test. (#6383)

* [ISSUE #6301] implement the CmdbSelectorContextBuilder and move the 1.x LabelSelector logic to CmdbLabelSelector and add unit test.

* [ISSUE #6301] remove the unused method.

* [ISSUE #6301] fix ci issue.
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Jul 29, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 4, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 4, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 4, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 4, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 4, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 4, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 5, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 5, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 5, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 5, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 5, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 6, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 8, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 9, 2021
… feature-alibaba#6301-integrate

� Conflicts:
�	console/src/main/resources/static/js/main.js
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 9, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 9, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 9, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 9, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 10, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 10, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 13, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 13, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 16, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 17, 2021
KomachiSion pushed a commit that referenced this issue Aug 18, 2021
…e Selector in 1.x. (#6680)

* [ISSUE #6301] replace the Selector in 1.x.

* [ISSUE #6301] remove the annotation of API(get all selector types).
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 18, 2021
KomachiSion pushed a commit that referenced this issue Aug 20, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Aug 20, 2021
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Sep 2, 2021
…tps://github.com/brotherlu-xcq/nacos into feature-alibaba#6301-integrate-3

� Conflicts:
�	naming/src/main/java/com/alibaba/nacos/naming/push/v2/task/PushExecuteTask.java
brotherlu-xcq added a commit to brotherlu-xcq/nacos that referenced this issue Sep 2, 2021
KomachiSion pushed a commit that referenced this issue Sep 9, 2021
…e the new Selector logic into 2.x. (#6720)

* [ISSUE #6301] [TASK 3] integrate Selector into Nacos 2.x.

* new compute logic in 2.x

* [ISSUE #6301] the compute logic.

* [ISSUE #6430] remove the unused code and remove the cache logic in Udp push task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants