Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Selector] [Sub Issue] Implement the built-in Selector in Nacos 1.x and add unit test. #6365

Closed
brotherlu-xcq opened this issue Jul 15, 2021 · 0 comments · Fixed by #6383
Closed

[Feature Selector] [Sub Issue] Implement the built-in Selector in Nacos 1.x and add unit test. #6365

brotherlu-xcq opened this issue Jul 15, 2021 · 0 comments · Fixed by #6383
Labels
kind/enhancement Category issues or prs related to enhancement.

Comments

@brotherlu-xcq
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

This issue is the sub issue of #6301.

Describe the solution you'd like

Implement the built-in LableSelecotr, CMDBSelectoerContextBuilder, which can match the most scene and the implement in Nacos 1.x, Add unit test for the built-in implement.

Describe alternatives you've considered
NO

Additional context
No
@brotherlu-xcq brotherlu-xcq mentioned this issue Jul 15, 2021
Closed
@realJackSun realJackSun added the kind/enhancement Category issues or prs related to enhancement. label Jul 16, 2021
@brotherlu-xcq brotherlu-xcq changed the title [Feature Selector][Sub Issue] Implement the built-in Selector in Nacos 1.x and add unit test. [Feature Selector] [Sub Issue] Implement the built-in Selector in Nacos 1.x and add unit test. Jul 16, 2021
@brotherlu-xcq brotherlu-xcq mentioned this issue Jul 19, 2021
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue Jul 20, 2021
@brotherlu-xcq
[ISSUE #6365] Implement the built-in Selector in Nacos 1.x and add un…
784cc82 
…it test. (#6383)

* [ISSUE #6301] implement the CmdbSelectorContextBuilder and move the 1.x LabelSelector logic to CmdbLabelSelector and add unit test.

* [ISSUE #6301] remove the unused method.

* [ISSUE #6301] fix ci issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #6365] Implement the built-in Selector in Nacos 1.x and add unit test. brotherlu-xcq/nacos
2 participants
@brotherlu-xcq @realJackSun