Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #5095] Add unit test for SelfHostnameVerifier #6428

Merged
merged 2 commits into from
Jul 23, 2021
Merged

[ISSUE #5095] Add unit test for SelfHostnameVerifier #6428

merged 2 commits into from
Jul 23, 2021

Conversation

SunJiFengPlus
Copy link
Contributor

@SunJiFengPlus SunJiFengPlus commented Jul 22, 2021 •
edited
Loading

What is the purpose of the change

The nacos-common in nacos 2.0 module coverage rate is too low.
For #5095

Brief changelog

  • replace the variable with constant
  • add unit test case

Verifying this change

before coverage
after coverage

@KomachiSion KomachiSion merged commit 727446c into alibaba:develop Jul 23, 2021
@SunJiFengPlus SunJiFengPlus deleted the SelfHostnameVerifier branch August 6, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
area/Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SunJiFengPlus @KomachiSion