Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for module nacos-common in nacos 2.0 #5095

Closed
realJackSun opened this issue Mar 12, 2021 · 3 comments
Closed

Add unit tests for module nacos-common in nacos 2.0 #5095

realJackSun opened this issue Mar 12, 2021 · 3 comments
Labels
area/Test expired No active for a long time

Comments

@realJackSun
Copy link
Collaborator

realJackSun commented Mar 12, 2021 •
edited
Loading

This is a sub-issue of [ISSUE #4981]
The nacos-common in nacos 2.0 module coverage rate is too low, this ISSUE aims to adding more unit tests to nacos-common module.
@realJackSun realJackSun mentioned this issue Mar 12, 2021
Open
6 tasks
@realJackSun realJackSun changed the title Add unit tests for module nacos-common Add unit tests for module nacos-common in nacos 2.0 Mar 12, 2021
@SunJiFengPlus
Copy link
Contributor

Please assign it to me, I will solve it.

@SunJiFengPlus SunJiFengPlus mentioned this issue Jun 29, 2021
Merged
KomachiSion pushed a commit that referenced this issue Jun 30, 2021
[ISSUE #5095]Add unit test for VersionUtils (#6195)
8dcf38f 
* replace with try with resource

* replace with lambda

* add unit test

* inline variable
ZZQ001010 pushed a commit to ZZQ001010/nacos that referenced this issue Jun 30, 2021
@ZZQ001010
[ISSUE alibaba#5095]Add unit test for VersionUtils (alibaba#6195)
ea74095 
* replace with try with resource

* replace with lambda

* add unit test

* inline variable
@SunJiFengPlus SunJiFengPlus mentioned this issue Jul 1, 2021
Merged
@SunJiFengPlus
Copy link
Contributor

At present, the test coverage of common module

KomachiSion pushed a commit that referenced this issue Jul 1, 2021
[ISSUE #5095] Add unit test for InternetAddressUtil (#6222)
16734cd 
* add unit test to InternetAddressUtil

* inline variable

* simplify assert
@SunJiFengPlus SunJiFengPlus mentioned this issue Jul 2, 2021
Merged
SunJiFengPlus pushed a commit to SunJiFengPlus/nacos that referenced this issue Jul 2, 2021
[ISSUE alibaba#5095] Add unit test for CollectionUtils
d703339
KomachiSion pushed a commit that referenced this issue Jul 2, 2021
[ISSUE #5095] Add unit test for CollectionUtils (#6251)
97abc6d
@SunJiFengPlus SunJiFengPlus mentioned this issue Jul 5, 2021
Merged
KomachiSion pushed a commit that referenced this issue Jul 8, 2021
[ISSUE #5095] Add unit test for ConvertUtils (#6269)
26caf8e 
* 100% cover ConvertUtils

* delete dead code

* simplify code
@SunJiFengPlus SunJiFengPlus mentioned this issue Jul 11, 2021
Merged
KomachiSion pushed a commit that referenced this issue Jul 12, 2021
[ISSUE #5095] Add unit test for ClassUtils (#6327)
f326a0c 
* fix typo

* add unit test for ClassUtils
SunJiFengPlus pushed a commit to SunJiFengPlus/nacos that referenced this issue Jul 21, 2021
[ISSUE alibaba#5095] Add unit test for JacksonUtils
6260dbf
@SunJiFengPlus SunJiFengPlus mentioned this issue Jul 21, 2021
Merged
KomachiSion pushed a commit that referenced this issue Jul 22, 2021
[ISSUE #5095] Add unit test for JacksonUtils (#6415)
7587bf7
SunJiFengPlus pushed a commit to SunJiFengPlus/nacos that referenced this issue Jul 22, 2021
[ISSUE alibaba#5095] Add unit test for SelfHostnameVerifier
724bec4
@SunJiFengPlus SunJiFengPlus mentioned this issue Jul 22, 2021
Merged
KomachiSion pushed a commit that referenced this issue Jul 23, 2021
[ISSUE #5095] Add unit test for SelfHostnameVerifier (#6428)
727446c 
* replace the variable with a constant

* [ISSUE #5095] Add unit test for SelfHostnameVerifier
@SunJiFengPlus SunJiFengPlus mentioned this issue Jul 25, 2021
Merged
KomachiSion pushed a commit that referenced this issue Jul 26, 2021
[ISSUE #5095] Add unit test for TlsFileWatcher (#6453)
c464f7c 
* Add unit test for TlsFileWatcher

* replace explicit type argument with <>

* replace anonymous Runnable with lambda

* 'catch' parameter named 'ignored' is used

* adjust log style
@SunJiFengPlus SunJiFengPlus mentioned this issue Jul 27, 2021
Merged
KomachiSion pushed a commit that referenced this issue Jul 27, 2021
[ISSUE #5095] Add unit test for RpcClientFactory (#6471)
e3c9fcf 
* fix typo

* Add unit test for RpcClientFactory
This was referenced Aug 2, 2021
Closed
Merged
@SunJiFengPlus SunJiFengPlus mentioned this issue Aug 10, 2021
Merged
This was referenced Sep 20, 2021
Merged
Merged
Merged
KomachiSion pushed a commit that referenced this issue Sep 23, 2021
[ISSUE #5095] Add some testcases for common executor (#6959)
cf2b4a5 
* add some testcases for common executor

* style
KomachiSion pushed a commit that referenced this issue Sep 23, 2021
[ISSUE #5095] Add testcase for common base64 (#6952)
cdd2a8f 
* add testcase for common base64

* testcase

* license
KomachiSion pushed a commit that referenced this issue Sep 23, 2021
[ISSUE #5095] Add some testcases for common cache (#6950)
a74eb55 
* add testcase for common cache

* license
@stale
Copy link

stale bot commented Jan 9, 2022

Thanks for your feedback and contribution. But the issue/pull request has not had recent activity more than 180 days. This issue/pull request will be closed if no further activity occurs 7 days later.
We may solve this issue in new version. So can you upgrade to newest version and retry?
If there are still issues or want to contribute again. Please create new issue or pull request again.

@stale stale bot added the expired No active for a long time label Jan 9, 2022
@stale stale bot closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/Test expired No active for a long time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wangweizZZ @SunJiFengPlus @realJackSun