Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5095] Add unit test for TlsFileWatcher #6453

Merged
merged 5 commits into from
Jul 26, 2021

Conversation

SunJiFengPlus
Copy link
Contributor

What is the purpose of the change

The nacos-common in nacos 2.0 module coverage rate is too low.
For #5095

Brief changelog

  • add unit test case
  • replace explicit type argument with <>
  • replace anonymous Runnable with lambda
  • rename parameter because of catch parameter named 'ignored' is used
  • adjust log style

Verifying this change

before coverage
after coverage

@KomachiSion KomachiSion added this to the 2.0.3 milestone Jul 26, 2021
@KomachiSion KomachiSion merged commit c464f7c into alibaba:develop Jul 26, 2021
@SunJiFengPlus SunJiFengPlus deleted the TlsFileWatcher branch July 26, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants