Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Cleaning Jobs for Plugins #11

Closed
5 tasks done
aljawaid opened this issue Apr 25, 2023 · 8 comments
Closed
5 tasks done

Create Cleaning Jobs for Plugins #11

aljawaid opened this issue Apr 25, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@aljawaid
Copy link
Owner

aljawaid commented Apr 25, 2023

  • Create JSON file to store all relevant plugin information
  • Create helper
  • Create model
  • Create controller for modal form
  • Add job to template
@aljawaid aljawaid added enhancement New feature or request help wanted Extra attention is needed labels Apr 25, 2023
@aljawaid aljawaid added this to the Plugin Cleaning Job milestone Apr 25, 2023
aljawaid added a commit that referenced this issue Apr 25, 2023
aljawaid added a commit that referenced this issue Apr 25, 2023
aljawaid added a commit that referenced this issue Apr 25, 2023
@aljawaid
Copy link
Owner Author

aljawaid commented Apr 26, 2023

JSON Examples:

JSON for Plugins with Database Tables

"1": {
        "plugin_name": "metamagik",
        "plugin_author": "Craig Crosby",
        "plugin_url": "https://github.com/creecros/MetaMagik",
        "checked_upto_plugin_version": "1.5.5",
        "plugin_tables": ["metadata_has_type", "metadata_types"],
        "plugin_schema_version": 7
    }

JSON for Plugins with Database Tables and Additional Core Columns

"2": {
        "plugin_name": "costcontrol",
        "plugin_author": "aljawaid",
        "plugin_url": "https://github.com/aljawaid/CostControl",
        "checked_upto_plugin_version": "1.1",
        "plugin_tables": ["hourly_rates", "budget_lines"],
        "core_table_columns": [
            {"currencies": ["last_modified", "comment", "live_rate", "live_rate_updated"]}
        ],
        "plugin_schema_version": 1
    }

JSON for Plugins with Database Tables and Entries in Core Tables

"6": {
        "plugin_title": "Wiki",
        "plugin_name": "wiki",
        "plugin_author": "lastlink",
        "plugin_url": "https://github.com/funktechno/kanboard-plugin-wiki",
        "checked_upto_plugin_version": "0.3.3",
        "plugin_tables": ["wikipage", "wikipage_has_files", "wikipage_editions"],
        "core_table_entries": [
            {"settings": ["persistEditions"]}
        ],
        "plugin_schema_version": 8
    }

@aljawaid
Copy link
Owner Author

aljawaid commented Apr 26, 2023

JSON Keys:

  • "2": {
    • Identification number to match the cleaning job number
  • "plugin_name":
    • Plugin name as saved in plugin_schema_versions table
  • "plugin_author":
    • Plugin author name
  • "plugin_url":
    • URL is needed in case of forks/plugins with the same name
    • Will be shown in the template
  • "checked_upto_plugin_version":
    • For easy reference and future updates
    • Will be shown in the template
  • "plugin_tables":
    • Database tables which are added by the plugin
    • Will be shown as a list in the template
    • Will be shown as a count in the template
  • "core_table_columns":
    • Additional columns in core database tables
    • Will be shown as a list in the template
    • Will be shown as a count in the template
  • "core_table_entries":
    • Entries in core database tables which need to be deleted
  • "plugin_schema_version":
    • The schema version set for the plugin in plugin_schema_versions table
    • Will be used to delete the entry from the table matching the plugin name

@aljawaid aljawaid pinned this issue Apr 26, 2023
aljawaid added a commit that referenced this issue Apr 26, 2023
aljawaid added a commit that referenced this issue Apr 26, 2023
aljawaid added a commit that referenced this issue Apr 26, 2023
aljawaid added a commit that referenced this issue Apr 26, 2023
aljawaid added a commit that referenced this issue Apr 26, 2023
aljawaid added a commit that referenced this issue Apr 27, 2023
@aljawaid
Copy link
Owner Author

image

Rough draft of template

aljawaid added a commit that referenced this issue Apr 30, 2023
aljawaid added a commit that referenced this issue May 1, 2023
aljawaid added a commit that referenced this issue May 1, 2023
aljawaid added a commit that referenced this issue May 1, 2023
aljawaid added a commit that referenced this issue May 1, 2023
aljawaid added a commit that referenced this issue May 1, 2023
aljawaid added a commit that referenced this issue May 1, 2023
aljawaid added a commit that referenced this issue May 2, 2023
aljawaid added a commit that referenced this issue May 6, 2023
aljawaid added a commit that referenced this issue May 6, 2023
aljawaid added a commit that referenced this issue May 6, 2023
aljawaid added a commit that referenced this issue May 6, 2023
aljawaid added a commit that referenced this issue May 7, 2023
- make use of screen space
- #11
@aljawaid
Copy link
Owner Author

aljawaid commented May 7, 2023

024a4cf

74bc48f

@aljawaid
Copy link
Owner Author

aljawaid commented May 8, 2023

@creecros The frontend for the plugin jobs is done. Any tips of how to do the functioning for deleting the stuff?

I think I can re-use functions like delete table or delete column... am sure I saw them in the code.

Any tips?

aljawaid added a commit that referenced this issue May 8, 2023
aljawaid added a commit that referenced this issue May 8, 2023
aljawaid added a commit that referenced this issue May 8, 2023
aljawaid added a commit that referenced this issue May 9, 2023
aljawaid added a commit that referenced this issue May 9, 2023
@aljawaid
Copy link
Owner Author

Screenshots c2d4b12

@aljawaid
Copy link
Owner Author

@creecros still busy?

@creecros
Copy link
Collaborator

Yes and no, I'll try and get back into it

aljawaid added a commit that referenced this issue Jul 9, 2023
aljawaid added a commit that referenced this issue Jul 12, 2023
aljawaid added a commit that referenced this issue Jul 15, 2023
aljawaid added a commit that referenced this issue Jul 16, 2023
aljawaid added a commit that referenced this issue Jul 18, 2023
aljawaid added a commit that referenced this issue Jul 21, 2023
- now set as 'table > column > row'
- #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants