button 1 = delete plugin (all functions)

[aljawaid]

No description provided.

[aljawaid]

@alfredbuehler @creecros Hello, this is the last issue for this plugin and it is ready for the release finally, but I have a question...

All the individual steps for deleting a plugin have been done. Now they all need to be completed through the 'delete plugin' button, which does all the parts (schema, tables, entries etc) and totally removes the plugin.

Is this model function correct with the controller? I'm struggling to understand how to combine all the other functions into the delete plugin function:

Modal Button:

ContentCleaner/Template/config/modals/plugin_delete.php

Line 101 in c75f5a2

<?= $this->modal->confirmButtons('PluginCleaningController', 'deletePlugin', array('plugin_job_name' => $plugin_job_name, 'plugin' => 'ContentCleaner'), t('Delete Plugin')) ?>

Controller:

ContentCleaner/Controller/PluginCleaningController.php

Line 47 in c75f5a2

public function deletePlugin($plugin_name)

Model:

ContentCleaner/Model/PluginCleaningModel.php

Line 16 in c75f5a2

public function deletePlugin($plugin_name)

Could you kindly check and advise? I think my model function is wrong but I am not exactly sure what to do next and why it is wrong. I just need one or both of your expert opinions.

[alfredbuehler]

I'm currently on vacation, but I'll might have a look into it next week.

[aljawaid]

I'm currently on vacation, but I'll might have a look into it next week.

thanks, I look forward to it. Have a nice holiday.

[alfredbuehler]

All the individual steps for deleting a plugin have been done.
Are they tested and working?

Is this model function correct with the controller? I'm struggling to understand how to combine all the other functions into the delete plugin function:

There is indeed some weirdness in using the controller function and downwards.

[alfredbuehler]

There are issues in front of the controller. If I try to delete the installed AddressBook plugin, the donut rotates forever, but the controller function deletePlugin is never called. I cannot debug this. And the amount of work to fix or complete the overall deleting is far too huge for me.

[aljawaid]

ok no problem, thanks for trying