Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

research contribution key is not recognized #399

Closed
aybehrouz opened this issue Apr 14, 2022 · 5 comments
Closed

research contribution key is not recognized #399

aybehrouz opened this issue Apr 14, 2022 · 5 comments

Comments

@aybehrouz
Copy link

Describe the bug
Research contribution key is not recognized.

Expected behavior
research is a valid key: https://allcontributors.org/docs/en/emoji-key

Screenshots
image

@aybehrouz aybehrouz added the bug Something isn't working label Apr 14, 2022
@Berkmann18 Berkmann18 transferred this issue from all-contributors/all-contributors Aug 16, 2022
@Berkmann18
Copy link
Member

Good point; it's not in https://github.com/all-contributors/app/blob/master/lib/parse-comment.js, would you say it's the only keyword missing, or would there be any other related to research that would make it easier to type while the bot still recognises the comment is about the research contribution type?

@aybehrouz
Copy link
Author

aybehrouz commented Aug 16, 2022

I think it's the only keyword missing and I think research itself is a good keyword.

By the way I think that would be great if you guys could add some new contribution types for "social media management" and also "project promotion/advertisement".

@Berkmann18
Copy link
Member

@tenshiAMD @gr2m What do you guys think?

@gr2m
Copy link
Contributor

gr2m commented Sep 8, 2022

I think we can add research and another one to cover social media / advertisement, such as promotion?

@tenshiAMD tenshiAMD added pinned good first issue Good for newcomers labels Sep 11, 2022
mstomar698 added a commit to mstomar698/app that referenced this issue Oct 3, 2022
We are adding research and promotion keywords to parse-comment.js for Issue all-contributors#399
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

🎉 This issue has been resolved in version 1.16.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants