Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define research and promotion contribution types #428

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

mstomar698
Copy link
Contributor

What: Adding new keywords to parse-comment.js

Checklist:

  • Documentation
  • Ready to be merged
  • Added myself to contributors table.
    Bot Usage

We are adding research and promotion keywords to parse-comment.js for Issue all-contributors#399
@mstomar698 mstomar698 requested a review from a team as a code owner October 3, 2022 19:55
@vercel
Copy link

vercel bot commented Oct 3, 2022

@201b153 is attempting to deploy a commit to the All Contributors Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@tenshiAMD tenshiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@201b153 Looks like something is missing. where do we add the emoji?

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4f3a74c) compared to base (17b99a6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #428   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          407       407           
  Branches        46        46           
=========================================
  Hits           407       407           
Impacted Files Coverage Δ
lib/parse-comment.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mstomar698
Copy link
Contributor Author

mstomar698 commented Oct 4, 2022

@201b153 Looks like something is missing. where do we add the emoji?

Do we have to add emojis too??
where I don't read it in the issue can u guide me here?

image

@tenshiAMD tenshiAMD changed the title Update parse-comment.js fix: define scope for research contribution type Oct 4, 2022
Copy link
Member

@tenshiAMD tenshiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to add emojis too?? where I don't read it in the issue can u guide me here?

image

@201b153 Thanks for this one. LGTM now. I just noticed now that the emoji keys are in the CLI codebase. 😕 I think will do some refactoring later on regarding this one.

@mstomar698
Copy link
Contributor Author

@201b153 Thanks for this one. LGTM now. I just noticed now that the emoji keys are in the CLI codebase. 😕 I think will do some refactoring later on regarding this one.

Ok, Thanks

Copy link
Member

@tenshiAMD tenshiAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to complete all todos.

@@ -35,6 +35,8 @@ const validContributionTypes = [
"tutorial",
"usertesting",
"video",
"research",
"promotion",
Copy link
Member

@tenshiAMD tenshiAMD Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tenshiAMD tenshiAMD changed the title fix: define scope for research contribution type fix: define research and promotion contribution types Oct 4, 2022
@tenshiAMD
Copy link
Member

@all-contributors add @201b153 for code

@allcontributors
Copy link
Contributor

@tenshiAMD

I've put up a pull request to add @201b153! 🎉

@tenshiAMD tenshiAMD merged commit 3b8b079 into all-contributors:master Oct 4, 2022
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

🎉 This PR is included in version 1.16.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants