Skip to content

Commit

Permalink
fix(helm): Add missing extraConfigs template volume mapping and fix t…
Browse files Browse the repository at this point in the history
…ype error on template. (apache#13613)

* Add volume mapping for superset-extra-config

* Fix wrong type for VALUE, cannot use "." inside range.

Fixes Error: template: superset/templates/configmap-superset.yaml:30:16: executing "superset/templates/configmap-superset.yaml" at <.>: wrong type for value; expected chartutil.Values; got string
  • Loading branch information
danielewood authored and Allan Caetano de Oliveira committed May 21, 2021
1 parent f74b502 commit 7a3c100
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion helm/superset/templates/configmap-superset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ metadata:
data:
{{- range $path, $config := .Values.extraConfigs }}
{{ $path }}: |
{{ tpl $config . | indent 4 -}}
{{- tpl $config $ | nindent 4 -}}
{{- end -}}
{{- end -}}
10 changes: 10 additions & 0 deletions helm/superset/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ spec:
- name: superset-config
mountPath: {{ .Values.configMountPath | quote }}
readOnly: true
{{- if .Values.extraConfigs }}
- name: superset-extra-config
mountPath: {{ .Values.extraConfigMountPath | quote }}
readOnly: true
{{- end }}
ports:
- name: http
containerPort: {{ .Values.service.port }}
Expand All @@ -97,3 +102,8 @@ spec:
- name: superset-config
secret:
secretName: {{ tpl .Values.configFromSecret . }}
{{- if .Values.extraConfigs }}
- name: superset-extra-config
configMap:
name: {{ template "superset.fullname" . }}-extra-config
{{- end }}

0 comments on commit 7a3c100

Please sign in to comment.