Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Add missing extraConfigs template volume mapping and fix type error on template. #13613

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

danielewood
Copy link
Contributor

@danielewood danielewood commented Mar 14, 2021

SUMMARY

Two parts:

  1. superset-extra-config configMap was not attached to the deployment container
  2. You cannot use "." inside a range with tpl. Instead "$" for global context can be used.

I also cleaned up the template slightly to result in the desired formatting no matter the input whitespace, thanks to @Yann-J for the feedback.

TEST PLAN

  1. Attempt to use extraConfigs:
test_config=$(cat<<'EOF'
extraConfigs:
  test.yaml: |
    test data
EOF
)
helm template deploytest superset -f - <<<"${test_config}"
  1. See error:
Error: template: superset/templates/configmap-superset.yaml:30:16: executing "superset/templates/configmap-superset.yaml" at <.>: wrong type for value; expected chartutil.Values; got string
  1. Apply this PR.
  2. Attempt to use extraConfigs
  3. Template builds configs, including volume maps

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Fixes Error: template: superset/templates/configmap-superset.yaml:30:16: executing "superset/templates/configmap-superset.yaml" at <.>: wrong type for value; expected chartutil.Values; got string
@junlincc junlincc requested a review from craig-rueda March 14, 2021 05:51
@junlincc junlincc added the new:contributor The author is a new contributor label Mar 14, 2021
@craig-rueda craig-rueda merged commit fc345b9 into apache:master Mar 15, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
…ype error on template. (apache#13613)

* Add volume mapping for superset-extra-config

* Fix wrong type for VALUE, cannot use "." inside range.

Fixes Error: template: superset/templates/configmap-superset.yaml:30:16: executing "superset/templates/configmap-superset.yaml" at <.>: wrong type for value; expected chartutil.Values; got string
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels new:contributor The author is a new contributor size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants