-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Move jupyter dependency to requirements_test. #645
Conversation
@DeNeutoy I think Jupyter is only used to test our notebooks. Do you know of any other uses for this dependency? |
It's used to actually run the tutorial notebooks if you have cloned the repo and want to interactively work through the tutorials, so I think it's probably best to leave it here? eg you can do:
in the root of the repo and then navigate to |
I see those notebooks as separate from our codebase and I think of Jupyter as a separate application to run those notebooks. Jupyter also has far more subdependencies (see below) than any other dependency as it's essentially an entire web application. We also install Jupyter in our setup.py--which definitely feels wrong to me since we don't distribute the notebooks with the pip installation. That said, I'm not an expert on distributing Python applications. I just put this PR together after a brief comment with @joelgrus, thinking it was a mistake.
|
if it were me, I probably wouldn't include but I don't feel super strongly about removing it. |
Up to you @DeNeutoy ! If you want to leave it in requirements.txt I'll remove it from setup.py. If you're OK removing it from requirements.txt, I'll update the instructions on our tutorials. With large dependency trees, I worry about nuanced dependency issues from incompatible transitive dependencies--particularly as we pin dependencies. |
Sure, updating instructions in the notebooks and removing it sounds fine. |
Cool. The following also convinced me this is a good idea:
|
* Move jupyter dependency to requirements_test. * Remove Jupyter from setup.py. * Add installing Jupyter to the notebook instructions.
No description provided.