Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Move jupyter dependency to requirements_test. #645

Merged
merged 3 commits into from
Dec 21, 2017
Merged

Move jupyter dependency to requirements_test. #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d94808
Move jupyter dependency to requirements_test.
schmmd Dec 21, 2017
953e779
Remove Jupyter from setup.py.
schmmd Dec 21, 2017
087df5a
Add installing Jupyter to the notebook instructions.
schmmd Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ tqdm
# In SQuAD eval script, we use this to see if we likely have some tokenization problem.
editdistance

# Tutorial notebooks
jupyter

# For pretrained model weights
h5py

Expand Down
3 changes: 3 additions & 0 deletions requirements_test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ pylint==1.8.1
# the tests. With this here, you can run the tests with `py.test` from the base directory.
pytest

# Tutorial notebooks
jupyter

# Static type checking
mypy

Expand Down
1 change: 0 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@
'requests>=2.18',
'tqdm',
'editdistance',
'jupyter',
'h5py',
'scikit-learn',
'scipy',
Expand Down
4 changes: 2 additions & 2 deletions tutorials/notebooks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ library. We recommend that you walk through them in the following order:
4. `Trainers`, `Models` and `Drivers`
5. Running experiments from JSON with AllenNLP.


To load a tutorial, follow the [install instructions](../../README.md) and then launch Jupyter.
To load a tutorial, follow the [install instructions](../../README.md) and install Jupyter
(`pip install jupyter`). Then you can launch Jupyter with the following.

```jupyter notebook```

Expand Down