Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AllureDisplayIgnored] Ignored tests are considered as new tests each time they are run #345

Closed
1 task done
KamilMarek-IV opened this issue May 15, 2023 · 2 comments · Fixed by #395
Closed
1 task done
Assignees
Labels

Comments

@KamilMarek-IV
Copy link

KamilMarek-IV commented May 15, 2023

I'm submitting a ...

  • bug report

What is the current behavior?

Whenever I run test suite, Ignored test is added to report as new test so overall test count increasing every run by ignored count

allure

in detailed report,

image

Same outcome when declared the same suite for ignored tests [AllureDisplayIgnored("suite name")]

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

test class marked with following attributes:

[AllureNUnit]
[AllureDisplayIgnored]
[AllureSuite("suite name")]
[Parallelizable(ParallelScope.Self)]

test method marked with following attributes:
[Ignore("Ignore reason")]
[Test, Timeout(180000)]
[Description("some desc")]
public async Task TestName()

Then run test suite multiple time and check reports

What is the expected behavior?

Whenever I run test suite, Ignored test is presented once in report, run is just added to history

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Other information

@undron
Copy link
Contributor

undron commented May 18, 2023

Looks like "historyId" is missing in *-result.json in this case.

@delatrie delatrie added the bug label Jul 8, 2023
@delatrie delatrie assigned delatrie and unassigned delatrie Jul 8, 2023
delatrie added a commit that referenced this issue Oct 12, 2023
UseLegacyIds option is honored.

Additionally:
  - fix uuid for containers
  - fix missing historyId for ignored tests. Same id rules apply as for non-ignored tests (fixes #345)
  - add NUnit 3 framework label to test results
  - remove suites from AllureDisplayIgnored (now suites can be applied directly)
  - fix parameter names for parametrized test methods
@delatrie delatrie linked a pull request Oct 12, 2023 that will close this issue
2 tasks
@delatrie delatrie self-assigned this Oct 12, 2023
neparij pushed a commit that referenced this issue Oct 12, 2023
* Bump NUnit for test and example projects

* Add json schemas for allureConfig and testplan

* Fix schema for allure-xunit and allure-specflow config

* Add legacy naming switch to config

* Update schema links to current branch

* Add schema links update task to release workflow

* Implement UUID and method-based fullName algorithms

* Common fns to calculate testCaseId, historyId and parameter value

* Add docstrings to new id-related functions

* Add function to create fullName from class

* Fix allureConfig item type for allure-nunit examples

* Add missing setter for UseLegacyIds config property

* Add framework label factory

* Fix uuid, fullName, historyId, testCaseId for allure-nunit

UseLegacyIds option is honored.

Additionally:
  - fix uuid for containers
  - fix missing historyId for ignored tests. Same id rules apply as for non-ignored tests (fixes #345)
  - add NUnit 3 framework label to test results
  - remove suites from AllureDisplayIgnored (now suites can be applied directly)
  - fix parameter names for parametrized test methods

* Apply custom formatters to step title and parameters

Now step title interpolation and step parameter value conversion uses the same
algorithm as test parameter conversions.

Fixes #377

* Add language label to commons and NUnit

* Fix uuid, fullName, historyId, testCaseId for allure-xunit

Legacy identifiers switch is honored.

Additionally:
  - Add framework and language labels to allure-xunit test results
  - Fix test parameters formatting. Custom type formatters are also used now

* Add no-formatters step helper overloads back to public API

* Revert autoedit this removal from StepFunctionTests.cs

* Fix uuid, fullName, historyId, testCaseId for allure-specflow

Legacy ids switch is honored.

Implements #387

* Implement requested changes
@delatrie
Copy link
Contributor

Hi, @undron !
The fix for the issue has just been released. Check out 2.10.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants