Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: File select and opening #23

Merged
merged 38 commits into from
Apr 11, 2019
Merged

WIP: File select and opening #23

merged 38 commits into from
Apr 11, 2019

Conversation

RvanderLaan
Copy link
Collaborator

Added functionality for selecting one or multiple files. Information about one or more selected files is shown in an Inspector component.
There is still some work to do for improving usability, the layout and the information that is shown

@hummingly hummingly added this to the Alpha v. 1.0 milestone Mar 30, 2019
@hummingly hummingly self-assigned this Mar 30, 2019
@hummingly
Copy link
Collaborator

hummingly commented Mar 31, 2019

Right now I'm restructuring the layout width css grid, so that on resize fixed elements aren't moved anywhere.

* .sidebar -> nav
* .main -> main
* .inspector -> aside & .inspectorSection -> aside > section
* Sidebar renamed to Outliner
Instead of using `position: fixed`, the sections are put into a grid layout. `overflow` is disabled except in the desired areas. Media queries are used to hide the inspector and outliner when the dimension are resized to a small size.
@hummingly
Copy link
Collaborator

@RvanderLaan If I understand it correctly, tag removal and file information are missing or are there more features needed?

@RvanderLaan
Copy link
Collaborator Author

Yep, those shouldn't be very difficult to implement.
I was already working on a search bar in the inspector to add and remove tags like this: https://blueprintjs.com/docs/#select/multi-select

And the selection of images can be improved, those circle check boxes don't serve any function anymore.

@hummingly
Copy link
Collaborator

Ok, I will look into reading image information and removing those circles.

@hummingly
Copy link
Collaborator

Right now there is a bug that when you click on a tag that does not contain the selected file, the app throws errors and becomes empty. The problem is that the files are removed in the file list which means the ClientFiles are removed in a way. Using an IFile array might be an idea if we want to continue showing even if they are not in the view. Another option is to remove the selection if it is not in the file list but it would be nice if we could remember the selection instead.

Additionally, the image metadata part is still missing.

Remi van der Laan added 2 commits April 3, 2019 21:56
But the search functionality is now broken for some reason
@RvanderLaan
Copy link
Collaborator Author

Nice changes!
About that bug, it would be more intuitive imo that the files that are not in the FileList are removed from the selection. Else you would have files selected that are not visible anymore, so you won't be able to deselect them.
But maybe that's just me, this should probably be decided by the designers.

@hummingly
Copy link
Collaborator

I removed this newline on chained calls lints. As long each then has a catch call it doesn't matter.

After we merged #31 we should merge this one. Anything else now depends on the design decision team.

@hummingly hummingly mentioned this pull request Apr 4, 2019
@hummingly hummingly mentioned this pull request Apr 11, 2019
@hummingly hummingly merged commit 2fb4f0c into master Apr 11, 2019
@hummingly hummingly deleted the file-select-and-opening branch April 11, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants